Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fswatch1
is being deprecated. This also gets rid of the uglyfind | xargs stat
shellery, as fsinfo gets us the modification time.fsinfo also gives us an initial 'change' event, so we don't need the "initial" and "on change" handler duplication.
This by and large works fine, but there is something really concerning: Instantiating an FsInfoClient breaks an existing
fswatch1
channel (which I could still understand, somehow interfering inotify's -- even though it should work). But it also breaks thethis never gets called any more. The D-Bus
notify
signal itself works, but cockpit.js then messes it up. This is somehow related to the newTransport
andChannel
classes.Debugging note for myself: