Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geo: simplify WKT conversion #70096

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

otan
Copy link
Contributor

@otan otan commented Sep 12, 2021

Avoid the geom.T -> WKB -> geom.T hop to convert WKT. This was a relic
of using GEOS.

Release justification: risk free performance improvement
Release note (performance improvement): WKT conversion to a spatial type
is slightly improved.

Avoid the geom.T -> WKB -> geom.T hop to convert WKT. This was a relic
of using GEOS.

Release justification: risk free performance improvement
Release note (performance improvement): WKT conversion to a spatial type
is slightly improved.
@otan otan requested review from sumeerbhola and a team September 12, 2021 20:27
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@otan otan changed the title ghgeo: simplify WKT conversion geo: simplify WKT conversion Sep 12, 2021
Copy link

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jievince
Copy link

Hi @otan, I wonder why when converting a ewkb to a geom.T, you just call the function ewkb.Unmarshal that provided by the library go-geom, but when converting a ewkt to a geom.T, you call the function wkt.Unmarshal which implemented by cockroach instead of the one that provided by go-geom?

@otan
Copy link
Contributor Author

otan commented Sep 13, 2021

we ported the wkt library for go-geom as it was written against CRDB first, we just haven't ported to use that yet. you can do that if you want!

Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @otan)

@jievince
Copy link

we ported the wkt library for go-geom as it was written against CRDB first, we just haven't ported to use that yet. you can do that if you want!

Got it.

@otan
Copy link
Contributor Author

otan commented Sep 14, 2021

bors r=sumeerbhola

@craig
Copy link
Contributor

craig bot commented Sep 14, 2021

Build succeeded:

@craig craig bot merged commit 3a60751 into cockroachdb:master Sep 14, 2021
@blathers-crl
Copy link

blathers-crl bot commented Sep 14, 2021

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


Backport to branch 21.1.x failed. See errors above.


Backport to branch 21.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants