-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geo: simplify WKT conversion #70096
geo: simplify WKT conversion #70096
Conversation
Avoid the geom.T -> WKB -> geom.T hop to convert WKT. This was a relic of using GEOS. Release justification: risk free performance improvement Release note (performance improvement): WKT conversion to a spatial type is slightly improved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @otan, I wonder why when converting a ewkb to a geom.T, you just call the function |
we ported the wkt library for go-geom as it was written against CRDB first, we just haven't ported to use that yet. you can do that if you want! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @otan)
Got it. |
bors r=sumeerbhola |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. Backport to branch 21.1.x failed. See errors above. Backport to branch 21.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Avoid the geom.T -> WKB -> geom.T hop to convert WKT. This was a relic
of using GEOS.
Release justification: risk free performance improvement
Release note (performance improvement): WKT conversion to a spatial type
is slightly improved.