testutils: add require library #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See doc.go for description. Add a library inspired by `github.com/stretchr/testify/require` but with simpler implementation and using generics. The benefit of generics is that we don't have to cast constants, e.g. `require.Equal(t, a, uint32(2))`). We also have some additional assertions around channel receive and function error argument unwrapping.
jbowens
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @RaduBerinde)
testutils/require/errors.go line 22 at r1 (raw file):
func NoError(tb TB, err error) { if err != nil { tb.Helper()
I like the change to move tb.Helper() into the error case so we can use it in benchmarks too
testutils/require/errors.go line 41 at r1 (raw file):
// // v := require.NoError1(SomeFunc()) func NoError1[T any](a T, err error) T {
good idea
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See doc.go for description.
Add a library inspired by
github.com/stretchr/testify/requirebutwith simpler implementation and using generics. The benefit of
generics is that we don't have to cast constants, e.g.
require.Equal(t, a, uint32(2))).We also have some additional assertions around channel receive and
function error argument unwrapping.
This change is