Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sstable: new property collector API #3784

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

sstable: new property collector API #3784

wants to merge 2 commits into from
+316 −452

Commits on Jul 22, 2024

  1. sstable: new property collector API 

    We simplify the property collector API: an instance now only needs to
maintain a single state, not three (data block, index, table). The
sstable writer uses multiple separate instances in parallel. The
instance for index blocks uses a new `AddCollected` API which adds
computed properties from the data blocks. Similarly, the table
properties are calculated in a separate instance using `AddCollected`
with the properties from the index blocks and the range key block.

This new interface will allow re-deriving index and table properties
for a partial file download which copies whole data blocks. In the
future, this would also allow copying entire data blocks during
compactions.
    @RaduBerinde
    RaduBerinde committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    232b685 View commit details
    Browse the repository at this point in the history

  2. sstable: use sync.Pool for interval block collectors

    @RaduBerinde
    RaduBerinde committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    b38f48b View commit details
    Browse the repository at this point in the history