Switch to SparkPost #1332
Closed
Switch to SparkPost #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
commented
Dec 21, 2017
| recipients: [%{name: user.first_name, email: user.email}], | ||
| substitution_data: %{ | ||
| from_name: "Code Corps", | ||
| from_email: "[email protected]", |
There was a problem hiding this comment.
These are identical everywhere, as far as I can tell, so maybe we add a helper module which builds the base model. I wouldn't stress about it yet, though.
begedin
commented
Dec 21, 2017
| with %StripeConnectCharge{user: %User{} = user} = charge <- Repo.preload(charge, :user), | ||
| %Project{} = project <- invoice.subscription |> get_project(), | ||
| {:ok, %DonationGoal{} = current_donation_goal} <- project |> get_current_donation_goal() | ||
| do |
There was a problem hiding this comment.
The email building can fail. I think this should go to the event handler. Data should be fetched/preloaded there.
begedin
commented
Dec 21, 2017
lib/code_corps/sparkpost/tasks.ex
Outdated
| defp load_css_file() do | ||
| File.cwd! |> Path.join("emails") |> Path.join("styles.css") |> File.read! | ||
| end | ||
| end |
There was a problem hiding this comment.
This file is probably a dialyzer nightmare right now. Need to clean it up
begedin
commented
Dec 21, 2017
| |> (fn list -> list -- @reserved_keys end).() | ||
| |> Enum.concat(@global_keys) | ||
| |> Enum.sort | ||
| end |
There was a problem hiding this comment.
Not a perfect helper, but should be helfpul
Setup basic API usage and testing infrastructure
begedin
force-pushed
the
1331-switch-to-sparkpost
branch
4 times, most recently
from
fde52e1
to
ad53de0
Compare
begedin
force-pushed
the
1331-switch-to-sparkpost
branch
from
14dd68d
to
93e3c00
Compare
begedin
force-pushed
the
1331-switch-to-sparkpost
branch
from
93e3c00
to
39d3541
Compare
begedin
force-pushed
the
1331-switch-to-sparkpost
branch
from
e9f1961
to
9cc8beb
Compare
begedin
force-pushed
the
1331-switch-to-sparkpost
branch
from
7b8798b
to
997479b
Compare
This was referenced Dec 22, 2017
begedin
force-pushed
the
develop
branch
18 times, most recently
from
e075407
to
6d6cc63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Things to do in this PR:
CodeCorps.EmailsReferences
Fixes #1331
Issues to add before merge
CodeCorps.Emails.Transmissions.Receipt- all with failure points should go into the event handler performing the email send.Receipt.buildshould not have a failure point. - Clean up CodeCorps.Emails.Transmissions.Receipt #1337