deflake LearningGoals by switching from useMemo to useEffect #64283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #64282. Speculative fix for https://codedotorg.atlassian.net/browse/TEACH-1639. Done in this PR:
afterInit
event handler as soon and reliably as possible viauseEffect
, rather than waiting until test cleanupA few reasons why my attention was drawn to this as a potential fix:
Testing story
Deployment strategy
merge #64282 and this PR into staging. wait a few days before merging any additional follow up work.
Future work
potential next steps:
jest --detectOpenHandles
(requires a repro, too slow to add to ci)