Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refinery reduction #49

Merged
merged 13 commits into from
Nov 11, 2024
Merged

Refinery reduction #49

merged 13 commits into from
Nov 11, 2024

Conversation

JWittmeyer
Copy link
Member

@JWittmeyer JWittmeyer commented Nov 6, 2024

PRs:

removes

  • Refinery-> Project Overview -> all charts but label distribution
  • Refinery -> Record IDE
  • Refinery -> Bricks Integrator (Attribute calc & heuristics) -> replaced with link to bricks

Todos

@JWittmeyer JWittmeyer marked this pull request as ready for review November 8, 2024 09:04
@lumburovskalina
Copy link
Collaborator

lumburovskalina commented Nov 8, 2024

After merge clear localStorage with the data from record-ide

  • resolved

JEdit:
Added tmp code to be removed after v1.18 release to remove the unused items when visiting the labeling page

@lumburovskalina
Copy link
Collaborator

lumburovskalina commented Nov 8, 2024

Suggestion: the dropdown can be above from the cards maybe? (there is a bigger gap between the dropdowns)
Screenshot 2024-11-08 at 15 00 38

  • resolved
  • ignored

Set full size width, same gap as cards & small margin left to start right above the ende of the rounded edge

@lumburovskalina
Copy link
Collaborator

lumburovskalina commented Nov 8, 2024

record-ide still in the route-manager

  • resolved

@lumburovskalina
Copy link
Collaborator

lumburovskalina commented Nov 8, 2024

record-ide.helper.ts is not removed
bricks-integrator.module.css is not removed

  • resolved

@lumburovskalina
Copy link
Collaborator

lumburovskalina commented Nov 8, 2024

A PR for the dev-setup for removal the record-ide is missing?

  • resolved

@lumburovskalina
Copy link
Collaborator

lumburovskalina commented Nov 8, 2024

record-ide still in the start script of the refinery-gateway

  • resolved

@JWittmeyer JWittmeyer merged commit e21e254 into dev Nov 11, 2024
1 check passed
@JWittmeyer JWittmeyer deleted the refinery-reduction branch November 11, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants