Skip to content

Commit

Permalink
Naver 앱의 class 들에 Naver prefix 추가
Browse files Browse the repository at this point in the history
  • Loading branch information
code-yeongyu committed Feb 10, 2022
1 parent b8f0937 commit af52411
Show file tree
Hide file tree
Showing 7 changed files with 30 additions and 21 deletions.
20 changes: 12 additions & 8 deletions src/app/naver/index.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,21 @@
import { NaverModule } from "./module";
import { ModuleFactory } from "./moduleFactory";
import { URLChanger } from "./urlChanger";
import { LoginEvent, CaptchaStatus, PageInteractor } from "./pageInteractor";
import { Service } from "./service";
import { NaverModuleFactory } from "./moduleFactory";
import { NaverURLChanger } from "./urlChanger";
import {
LoginEvent,
CaptchaStatus,
NaverPageInteractor,
} from "./pageInteractor";
import { NaverService } from "./service";
import { NaverScraper } from "./scraper";
import { NaverParser } from "./parser";

export {
NaverModule,
ModuleFactory,
URLChanger,
PageInteractor,
Service,
NaverModuleFactory,
NaverURLChanger,
NaverPageInteractor,
NaverService,
LoginEvent,
CaptchaStatus,
NaverScraper,
Expand Down
11 changes: 8 additions & 3 deletions src/app/naver/module.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
import { URLChanger, PageInteractor, NaverScraper, NaverParser } from ".";
import {
NaverURLChanger,
NaverPageInteractor,
NaverScraper,
NaverParser,
} from ".";

export interface NaverModule {
readonly urlChanger: URLChanger;
readonly pageInteractor: PageInteractor;
readonly urlChanger: NaverURLChanger;
readonly pageInteractor: NaverPageInteractor;
readonly scraper: NaverScraper;
readonly parser: NaverParser;
}
10 changes: 5 additions & 5 deletions src/app/naver/moduleFactory.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
import puppeteer from "puppeteer";
import {
NaverModule,
URLChanger,
PageInteractor,
NaverURLChanger,
NaverPageInteractor,
NaverScraper,
NaverParser,
} from ".";

export class ModuleFactory {
export class NaverModuleFactory {
static create(page: puppeteer.Page): NaverModule {
const urlChanger = new URLChanger(page);
const pageInteractor = new PageInteractor(page);
const urlChanger = new NaverURLChanger(page);
const pageInteractor = new NaverPageInteractor(page);
const scraper = new NaverScraper();
const parser = new NaverParser();

Expand Down
2 changes: 1 addition & 1 deletion src/app/naver/pageInteractor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export interface CaptchaStatus {
readonly question: string;
}

export class PageInteractor {
export class NaverPageInteractor {
constructor(private readonly page: puppeteer.Page) {
this.page = page;
}
Expand Down
2 changes: 1 addition & 1 deletion src/app/naver/service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
} from "rxjs";
import { NaverModule } from ".";

export class Service {
export class NaverService {
cookies?: string;
constructor(private readonly module: NaverModule) {
this.module = module;
Expand Down
4 changes: 2 additions & 2 deletions src/app/naver/urlChanger.test.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { URLChanger } from "./urlChanger";
import { NaverURLChanger } from "./urlChanger";

describe("URLChanger", () => {
describe("moveToLoginURL", () => {
it("Should move page to login", async () => {
// given
const urlChanger = new URLChanger(page);
const urlChanger = new NaverURLChanger(page);
const pageSpy = jest.spyOn(page, "goto");

// when
Expand Down
2 changes: 1 addition & 1 deletion src/app/naver/urlChanger.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import puppeteer from "puppeteer";

export class URLChanger {
export class NaverURLChanger {
constructor(private readonly page: puppeteer.Page) {
this.page = page;
}
Expand Down

0 comments on commit af52411

Please sign in to comment.