246 code cleanup notifications #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge upstream
merge develop
Merge from code4ro repo
decembrya
requested review from
aniri,
bvizureanu and
idormenco
as code owners
|
👀 |
|
@decembrya please fix merge issues and let's merge it |
aniri
approved these changes
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it fix?
part of #246
How has it been tested?
Tested manually
this cleanup PR will introduce braking changes for the client as follows:
POST methods will return 202 Accepted instead of 200 OK
GET api/v1/notification/get/all will take params from query string instead of body
POST api/v1/notification/send has a contract change -> recipient list will be list of int instead of string