Implement change password for refugee and fix it for host and admin as well #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anastk-code4 Would the current implementation be acceptable? Would you like me to change the translation to match the mockup? |
mihaipopescu
force-pushed
the
66-user-change-password
branch
2 times, most recently
from
a1f95ba
to
2c12585
Compare
|
something's still off. I can confirm the password is changed but to some wrong value since I can't login after logging out, neither with the new password nor with the old one. 🤔 |
The implementation is an adaptation from existing code found for host.
mihaipopescu
force-pushed
the
66-user-change-password
branch
from
2c12585
to
d25f556
Compare
newPassword was an empty value and that made me wonder whether the code was using the wrong key and since it was simpler renaming that instead of changing everything else to use newPassword I just did that.
|
ok, I found some time to debug the previous issue and figured it out. |
mihaipopescu
changed the title
|
@anastk-code4 can you verify if this implementation works for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it fix?
Addresses #66 to enable users to change their passwords but since it's reusing existing implementation found for the host/admin, it differs from the mockup described in #66.
Later I discovered that the existing implementation was broken so the PR addresses and fixes the password reset for host and admin as well.
Also, I've only added Romanian translation. I could have used Google Translate for the other languages but I think it's better the translators add a proper translation.
How has it been tested?
Locally.