Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/experiment_manager #10

Merged
merged 23 commits into from
May 28, 2024
Merged

Feat/experiment_manager #10

merged 23 commits into from
May 28, 2024

Conversation

ihsanKisi
Copy link

@ihsanKisi ihsanKisi commented Apr 25, 2024

📥 Pull Request Description

This pull request implements the experiment manager feature. This feature was requested to be able to filter experiments based on their properties.

👀 Affected Areas

Experiments

📝 Checklist

Please make sure you've completed the following tasks before submitting this pull request:

  • Pre-commit hooks were executed
  • Changes have been reviewed by at least one other developer
  • Tests have been added or updated to cover the changes (only necessary if the changes affect the executable code)
  • All tests ran successfully
  • All merge conflicts are resolved
  • Documentation has been updated to reflect the changes
  • Any necessary migrations have been run

📌 Related Issues

[Feature]: We have to manage the experiments in the dashboard. #2

🔗 Links

Please provide any relevant links (e.g. documentation, external resources) that support your changes.

📷 Screenshots

Without filtering (10 experiments):
image

With filtering by experiment_type:
image

@ihsanKisi ihsanKisi requested review from aiakide and Jankeyy April 25, 2024 10:36
@ihsanKisi ihsanKisi linked an issue Apr 25, 2024 that may be closed by this pull request
1 task
Copy link
Collaborator

@aiakide aiakide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge the current develop branch. Please pay attention to which files you commit. Not everything should be added to the repo.

@ihsanKisi ihsanKisi marked this pull request as draft April 25, 2024 13:08
@ihsanKisi ihsanKisi marked this pull request as ready for review May 7, 2024 07:42
@ihsanKisi ihsanKisi self-assigned this May 16, 2024
Copy link

github-actions bot commented May 23, 2024

Code Coverage

Coverage Report •
FileStmtsMissCoverMissing
__init__.py10100% 
dashboard.py13130%11–13, 17, 20, 25, 32, 34, 38–39, 42, 44–45
exceptions.py10100% 
basecomponents
   sidebar.py11110%13, 15, 17–18, 21, 24, 33, 36, 38–39, 48
   table.py990%12–16, 19–20, 30, 34
basecomponents/buttons
   __init__.py00100% 
   sidebarbutton.py11110%4–5, 7, 14, 19, 32–34, 36–37, 40
   sidebartogglebutton.py290100% 
experiment
   experimentmanager.py15846%21, 33–36, 41, 43, 48
pages
   home.py23230%13, 16, 22–25, 28–29, 34–38, 40–41, 43–50
state
   __init__.py00100% 
   appstate.py36360%7–9, 11–13, 15, 17, 20, 26, 31, 33, 37, 39, 49–50, 52–54, 57, 67–70, 73, 81–86, 89, 95, 100, 103, 108
TOTAL23212147% 

Pytest summary

Tests Skipped Failures Errors Time
11 0 💤 0 ❌ 0 🔥 5.332s ⏱️

Copy link
Collaborator

@aiakide aiakide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the comments. We can talk about it again.

class StateKeys(ABCMeta, EnumMeta):
"""
Provides an abstract class for StateKey management
"""


class EventManager:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a more appropriate class name. This is where our app data is stored. I qould suggest something like State, or AppState.

@aiakide aiakide merged commit 083a021 into develop May 28, 2024
9 checks passed
@aiakide aiakide deleted the feat-experiment-manager branch May 28, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: We have to manage the experiments in the dashboard.
3 participants