-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/experiment_manager #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge the current develop
branch. Please pay attention to which files you commit. Not everything should be added to the repo.
…nts, revert resource paths back to the original paths
resolved conflicts
…ng support with buttons, add enums for experiments, revert resource paths back to the original paths
Coverage Report •
Pytest summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at the comments. We can talk about it again.
nicemldashboard/State/State.py
Outdated
class StateKeys(ABCMeta, EnumMeta): | ||
""" | ||
Provides an abstract class for StateKey management | ||
""" | ||
|
||
|
||
class EventManager: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use a more appropriate class name. This is where our app data is stored. I qould suggest something like State
, or AppState
.
📥 Pull Request Description
This pull request implements the experiment manager feature. This feature was requested to be able to filter experiments based on their properties.
👀 Affected Areas
Experiments
📝 Checklist
Please make sure you've completed the following tasks before submitting this pull request:
📌 Related Issues
[Feature]: We have to manage the experiments in the dashboard. #2
🔗 Links
Please provide any relevant links (e.g. documentation, external resources) that support your changes.
📷 Screenshots
Without filtering (10 experiments):

With filtering by experiment_type:
