Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of the incorrect branch name of the development group #24

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

aiakide
Copy link
Collaborator

@aiakide aiakide commented Sep 13, 2024

📥 Pull Request Description

An incorrect branch name was still entered in the “develop” release group, which is to be used for the pre-release versions.
This has been corrected so that the 'develop' branch is used.

👀 Affected Areas

  • Release pipeline

📝 Checklist

Please make sure you've completed the following tasks before submitting this pull request:

  • Pre-commit hooks were executed
  • Changes have been reviewed by at least one other developer
  • Tests have been added or updated to cover the changes (only necessary if the changes affect the executable code)
  • All tests ran successfully
  • All merge conflicts are resolved
  • Documentation has been updated to reflect the changes
  • Any necessary migrations have been run

@aiakide aiakide self-assigned this Sep 13, 2024
@aiakide aiakide changed the base branch from main to develop September 13, 2024 13:58
Copy link

github-actions bot commented Sep 13, 2024

Code Coverage

Coverage Report •
FileStmtsMissCoverMissing
src/nicemldashboard
   __init__.py10100% 
   __main__.py00100% 
   app.py550%1–3, 5, 9
   dashboard.py32487%90, 92–93, 95
   pages.py66986%91–92, 95–97, 99, 102–104
src/nicemldashboard/basecomponents
   __init__.py00100% 
   common.py100100% 
   sidebar.py110100% 
   table.py100100% 
src/nicemldashboard/basecomponents/buttons
   __init__.py00100% 
   sidebarbutton.py9188%33
   sidebartogglebutton.py290100% 
src/nicemldashboard/detailview
   __init__.py00100% 
   detailviewcomponent.py401757%18–20, 23, 26, 30, 34, 37–38, 43, 46, 49, 53, 56, 61, 64, 67
src/nicemldashboard/experiment
   __init__.py00100% 
   experiment.py430100% 
   experimentmanager.py33875%46, 61, 67–69, 75, 102–103
   type.py18194%68
   utils.py17170%12–14, 16, 18–19, 21, 24, 37–40, 46–47, 50, 63–64
src/nicemldashboard/loader
   __init__.py00100% 
   dataframeloader.py24240%9–13, 18, 21, 29–30, 41, 44, 59, 71, 75, 95, 99, 102–103, 106, 108–111, 117
   experimentloader.py1162578%100, 132, 136, 140, 190–192, 213, 265, 275, 329, 331, 334, 336, 339, 353–356, 359, 365–369
   imageloader.py29293%41, 106
src/nicemldashboard/state
   __init__.py00100% 
   appstate.py60591%139, 165–166, 184–185
   statedata.py60100% 
   statekey.py50100% 
src/nicemldashboard/utils
   __init__.py00100% 
   exceptions.py40100% 
   images.py10100% 
   settings.py250100% 
TOTAL59411880% 

Pytest summary

Tests Skipped Failures Errors Time
49 0 💤 0 ❌ 0 🔥 2m 14s ⏱️

@aiakide aiakide requested a review from dstalzjohn September 13, 2024 14:02
@aiakide aiakide merged commit 57c1206 into develop Sep 13, 2024
9 checks passed
@aiakide aiakide deleted the fix/develop-release-group branch September 13, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants