Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update tensorflow and dagster #106

Conversation

TimoSchadt
Copy link
Contributor

@TimoSchadt TimoSchadt commented Jan 11, 2024

📥 Pull Request Description

  • Updated Dagster to Version 1.5 in order to leverage bug fixes in dagster webservice
  • Fix keras import error in order to enable usage of tensorflow 2.15

👀 Affected Areas

  • Dagster Pipelines & Webservice
  • Tensorflow ML Backend

📝 Checklist

Please make sure you've completed the following tasks before submitting this pull request:

  • Pre-commit hooks were executed
  • Changes have been reviewed by at least one other developer
  • Tests have been added or updated to cover the changes (only necessary if the changes affect the executable code)
  • All tests ran successfully
  • All merge conflicts are resolved
  • Documentation has been updated to reflect the changes
  • Any necessary migrations have been run

📌 Related Issues

If this pull request is related to an existing issue, please reference it here.

🔗 Links

Please provide any relevant links (e.g. documentation, external resources) that support your changes.

📷 Screenshots

If applicable, please include screenshots of the before and after effects of your changes.

Thank you for your contribution! 🎉

@TimoSchadt TimoSchadt closed this Jan 11, 2024
@TimoSchadt TimoSchadt reopened this Jan 11, 2024
@TimoSchadt TimoSchadt marked this pull request as ready for review January 11, 2024 09:03
pyproject.toml Outdated Show resolved Hide resolved
@aiakide aiakide changed the base branch from main to develop January 11, 2024 10:57
@aiakide
Copy link
Collaborator

aiakide commented Jan 11, 2024

We are currently discussing the possible versions of TensorFlow and Python. It looks like we will remove python 3.8 and use the lowest possible TensorFlow version as a minimum (maybe 2.13.) . The maximum TensorFlow version will be ~2.15.

Also, dagster 1.6.0 was released tonight. Let's add this version right away.

@aiakide aiakide added the 🔧 enhancement Requests for improvements or enhancements to existing features label Jan 11, 2024
Change Tensorflow version to >=2.13, <=2.15
@TimoSchadt TimoSchadt requested a review from ankeko January 12, 2024 12:52
Copy link
Collaborator

@aiakide aiakide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🎉

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@aiakide aiakide merged commit 9c3f6af into codecentric-oss:develop Jan 12, 2024
6 checks passed
aiakide pushed a commit that referenced this pull request Jan 16, 2024
…ove support for python `3.8` (#106)

## 📥 Pull Request Description

- Updated Dagster to Version 1.5 in order to leverage bug fixes in
dagster webservice
- Fix keras import error in order to enable usage of tensorflow 2.15

## 👀 Affected Areas

- Dagster Pipelines & Webservice
- Tensorflow ML Backend

## 📝 Checklist

Please make sure you've completed the following tasks before submitting
this pull request:

- [X] Pre-commit hooks were executed
- [x] Changes have been reviewed by at least one other developer
- [X] Tests have been added or updated to cover the changes (only
necessary if the changes affect the executable code)
- [ ] All tests ran successfully
- [X] All merge conflicts are resolved
- [ ] Documentation has been updated to reflect the changes
- [X] Any necessary migrations have been run

## 📌 Related Issues

If this pull request is related to an existing issue, please reference
it here.

## 🔗 Links

Please provide any relevant links (e.g. documentation, external
resources) that support your changes.

## 📷 Screenshots

If applicable, please include screenshots of the before and after
effects of your changes.

Thank you for your contribution! 🎉

---------

Co-authored-by: Timo Schadt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 enhancement Requests for improvements or enhancements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants