Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set pytest workflow trigger to pull_request_target #108

Merged
merged 5 commits into from
Jan 15, 2024

Conversation

aiakide
Copy link
Collaborator

@aiakide aiakide commented Jan 12, 2024

📥 Pull Request Description

The following changes and fixes are part of this pull request:

  • ci(test): Set pipeline trigger to pull_request_target to execute the pipeline even with fork pull requests
  • docs: Remove python 3.8 from Getting Started
  • refactor: Remove python from classifiers in pyproject.toml

👀 Affected Areas

  • pytest workflow
  • docs

📝 Checklist

Please make sure you've completed the following tasks before submitting this pull request:

  • Pre-commit hooks were executed
  • Changes have been reviewed by at least one other developer
  • Tests have been added or updated to cover the changes (only necessary if the changes affect the executable code)
  • All tests ran successfully
  • All merge conflicts are resolved
  • Documentation has been updated to reflect the changes
  • Any necessary migrations have been run

📌 Related Issues

@aiakide aiakide added 📚 documentation Related to documentation or the need for additional documentation ⚙️ configuration Related to project configuration or setup. ♻️ refactoring Related to refactoring or restructuring code labels Jan 12, 2024
@aiakide aiakide requested review from ankeko and dstalzjohn January 12, 2024 14:30
@aiakide
Copy link
Collaborator Author

aiakide commented Jan 15, 2024

closes #107

@aiakide aiakide merged commit 6a89c5f into develop Jan 15, 2024
6 checks passed
@aiakide aiakide deleted the fix/worklow-trigger branch January 15, 2024 10:03
aiakide added a commit that referenced this pull request Jan 16, 2024
…orkflow even with fork pull requests (#108)

## 📥 Pull Request Description

The following changes and fixes are part of this pull request:
- ci(test): Set pipeline trigger to `pull_request_target` to execute the
pipeline even with fork pull requests
- docs: Remove python 3.8 from Getting Started
- refactor: Remove python from classifiers in `pyproject.toml`
- ci(test): Add workflow trigger `pull_request` back into project

## 👀 Affected Areas

- pytest workflow
- docs

## 📝 Checklist

Please make sure you've completed the following tasks before submitting
this pull request:

- [X] Pre-commit hooks were executed
- [ ] Changes have been reviewed by at least one other developer
- [ ] Tests have been added or updated to cover the changes (only
necessary if the changes affect the executable code)
- [X] All tests ran successfully
- [X] All merge conflicts are resolved
- [X] Documentation has been updated to reflect the changes
- [ ] Any necessary migrations have been run

## 📌 Related Issues

- closes #107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ configuration Related to project configuration or setup. 📚 documentation Related to documentation or the need for additional documentation ♻️ refactoring Related to refactoring or restructuring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants