Fix: reload running or incomplete experiments in dashboard #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstalzjohn
approved these changes
Feb 8, 2024
ankeko
added a commit
that referenced
this pull request
Feb 8, 2024
## 📥 Pull Request Description The following changes, features and fixes are part of this pull request: - fix: simplify ExperimentManager using exp_dict (#114) - fix: query experiments based on storage handler name not mutable id (#114) - feat: update altair to 5.2.0 (#113) ## 👀 Affected Areas - Dashboard - Dependencies ## 📝 Checklist Please make sure you've completed the following tasks before submitting this pull request: - [x] Pre-commit hooks were executed - [x] Changes have been reviewed by at least one other developer - [ ] Tests have been added or updated to cover the changes (only necessary if the changes affect the executable code) - [x] All tests ran successfully - [x] All merge conflicts are resolved - [ ] Documentation has been updated to reflect the changes - [ ] Any necessary migrations have been run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📥 Pull Request Description
If the dashboard runs or is started during a training, the experiments is already shown in the dashboard. When the training finished, the experiment was not reloaded and was still shown as incomplete or vanished from the dashboard after a component was reloaded.
This PR fixes these problems, as the reloading routine was changed.
Additionally, the ExperimentManager was simplified to use only one type of experiment stash (dict instead of list and dict).
👀 Affected Areas
Dashboard
📝 Checklist
Please make sure you've completed the following tasks before submitting this pull request: