Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional arguments to the initialize method of a ResultAnalyzer #134

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

aiakide
Copy link
Collaborator

@aiakide aiakide commented Aug 7, 2024

📥 Pull Request Description

This PR adds the following features and changes:

  • feat: Add possibility to pass additional arguments when initializing a ResultAnalyzer
  • refactor: Add an experiment context to the initialize function of the DataframeAnalyzer
  • refactor: Pass the experiment context of a train or eval pipeline run to the result analyzer.

👀 Affected Areas

  • Result analyzers
  • Analyse op
  • Train and eval job

📝 Checklist

Please make sure you've completed the following tasks before submitting this pull request:

  • Pre-commit hooks were executed
  • Changes have been reviewed by at least one other developer
  • Tests have been added or updated to cover the changes (only necessary if the changes affect the executable code)
  • All tests ran successfully
  • All merge conflicts are resolved
  • Documentation has been updated to reflect the changes
  • Any necessary migrations have been run

@aiakide aiakide added the ✨ feature Requests or discussions about new features label Aug 7, 2024
@aiakide aiakide requested a review from ankeko August 7, 2024 10:01
@aiakide aiakide merged commit 6e48893 into develop Aug 7, 2024
6 checks passed
@aiakide aiakide deleted the feature/additional-result-analyser-argumens branch August 7, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature Requests or discussions about new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants