Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_image and write_image now use LocalFileSystem as default #140

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

aiakide
Copy link
Collaborator

@aiakide aiakide commented Dec 3, 2024

📥 Pull Request Description

Currently you cannot use read_image and write_image without specifying a FileSystem. The default (LocalFileSystem) was not used correctly. This is now fixed in this PR.

👀 Affected Areas

  • ioutils

📝 Checklist

Please make sure you've completed the following tasks before submitting this pull request:

  • Pre-commit hooks were executed
  • Changes have been reviewed by at least one other developer
  • Tests have been added or updated to cover the changes (only necessary if the changes affect the executable code)
  • All tests ran successfully
  • All merge conflicts are resolved
  • Documentation has been updated to reflect the changes
  • Any necessary migrations have been run

@aiakide aiakide added the 🪲 bug Related to bugs or unexpected behavior label Dec 3, 2024
@aiakide aiakide requested review from dstalzjohn and ankeko December 3, 2024 11:07
@dstalzjohn dstalzjohn enabled auto-merge (squash) December 3, 2024 11:14
@dstalzjohn dstalzjohn merged commit c835076 into develop Dec 3, 2024
6 checks passed
@aiakide aiakide deleted the fix/ioutils-default-fs branch December 3, 2024 11:36
aiakide added a commit that referenced this pull request Dec 3, 2024
…ult (#140)

## 📥 Pull Request Description

Currently you cannot use `read_image` and `write_image` without
specifying a FileSystem. The default (`LocalFileSystem`) was not used
correctly. This is now fixed in this PR.

## 👀 Affected Areas

- ioutils

## 📝 Checklist

Please make sure you've completed the following tasks before submitting
this pull request:

- [X] Pre-commit hooks were executed
- [ ] Changes have been reviewed by at least one other developer
- [ ] Tests have been added or updated to cover the changes (only
necessary if the changes affect the executable code)
- [X] All tests ran successfully
- [X] All merge conflicts are resolved
- [X] Documentation has been updated to reflect the changes
- [X] Any necessary migrations have been run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Related to bugs or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants