Release preparation v0.8.3 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## 📥 Pull Request Description This pull request fixes a bug, which created two experiment runs out of one dagster pipeline run. This is a bug, caused by the dagster itegration of MLFlow. The implementation in niceML was correct. When the bug of this package is fixed in the future, niceML may has to be updated as well. With this fix, niceML, dagster and MLFlow work and only one MLFlow experiment run is created per dagster pipeline run. ## 👀 Affected Areas Dagster Pipeline MLFlow integration ## 📝 Checklist Please make sure you've completed the following tasks before submitting this pull request: - [x] Pre-commit hooks were executed - [x] Changes have been reviewed by at least one other developer - [ ] Tests have been added or updated to cover the changes (only necessary if the changes affect the executable code) - [x] All tests ran successfully - [x] All merge conflicts are resolved - [ ] Documentation has been updated to reflect the changes - [ ] Any necessary migrations have been run
… a private function because lambdas are not pickable (#85) ## 📥 Pull Request Description Replace lambda `class_extractor` in `DirClsDataInfoListing` with a private function because lambdas are not pickable ## 📝 Checklist Please make sure you've completed the following tasks before submitting this pull request: - [x] Pre-commit hooks were executed - [x] Changes have been reviewed by at least one other developer - [ ] Tests have been added or updated to cover the changes (only necessary if the changes affect the executable code) - [x] All tests ran successfully - [x] All merge conflicts are resolved - [ ] Documentation has been updated to reflect the changes - [ ] Any necessary migrations have been run
## 📥 Pull Request Description Implemented option to generate pipeline graphs of dagster jobs with multiple op dependencies. ## 👀 Affected Areas Documentation ## 📝 Checklist Please make sure you've completed the following tasks before submitting this pull request: - [x] Pre-commit hooks were executed - [x] Changes have been reviewed by at least one other developer - [ ] Tests have been added or updated to cover the changes (only necessary if the changes affect the executable code) - [x] All tests ran successfully - [x] All merge conflicts are resolved - [ ] Documentation has been updated to reflect the changes - [ ] Any necessary migrations have been run
## 📥 Pull Request Description If the dashboard was started during a running experiment, the experiment was visible in the dashboard but with incomplete information. Even after the experiment was finished, the Cache was not updated, so the experiment would still be incomplete in the dashboard. This issue was fixed by checking for the latest modification in the experiment files and updating the cache, if it was outdated. Additionaly, the test pipeline was fixed, by defining the execution sequence of tests. ## 👀 Affected Areas - dashboard - test pipeline ## 📝 Checklist Please make sure you've completed the following tasks before submitting this pull request: - [x] Pre-commit hooks were executed - [x] Changes have been reviewed by at least one other developer - [x] Tests have been added or updated to cover the changes (only necessary if the changes affect the executable code) - [x] All tests ran successfully - [x] All merge conflicts are resolved - [ ] Documentation has been updated to reflect the changes - [ ] Any necessary migrations have been run --------- Co-authored-by: Denis Stalz-John <[email protected]>
aiakide
added
🪲 bug
ankeko
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📥 Pull Request Description
This pull request includes the following fixes:
class_extractorinDirClsDataInfoListingwith a private function because lambdas are not pickable (datasets and all components need to be pickable, and lambdas are not #85)👀 Affected Areas
📝 Checklist
Please make sure you've completed the following tasks before submitting this pull request: