Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor render register file #38

Conversation

angelina-momin
Copy link
Collaborator

@angelina-momin angelina-momin commented Apr 26, 2024

Made the following changes:

  • Created separate functions for each register rendering and register checking utility in register.R
  • Moved preprocessing utility functions to file utils_preprocess_register.R
  • Moved rendering utility functions to file utils_render_register.R
  • Moved register checking utility functions to file utils_register_check.R
  • Added myself as an author in the DESCRIPTION file
  • Bump version from 0.1.0.9005 to 0.1.0.9006 in the DESCRIPTION file
  • Updated workflow file R-CMD-check.yaml to use r-lib's v2-branch instead of master branch. Otherwise the workflow runs fail. The "master" branch was replaced with "v2-branch"

Already tested it out by running the function and checking the results and it looks good.

@angelina-momin
Copy link
Collaborator Author

angelina-momin commented Apr 26, 2024

@nuest I cannot add anyone as reviewer so I am tagging you here to ask for a review.

@angelina-momin
Copy link
Collaborator Author

angelina-momin commented Apr 26, 2024

@nuest The checks are failing because r-lib/actions no longer has a master branch: link. Their default branch is now called "v2-branch". Should I update the workflow file and replace "master" with "v2-branch"?

@nuest nuest self-assigned this May 6, 2024
@nuest
Copy link
Member

nuest commented May 6, 2024

Hi @angelina-momin !
Yes, please do update the workflow file as you see fit.

Changes look good to me, only one more thing: Can you please bump the development version to 0.1.0.9006 in the DESCRIPTION file, see https://github.com/codecheckers/codecheck/blob/master/DESCRIPTION#L3C10-L3C20
Also, your personal details are missing in the DESCRIPTION file.

Once you changes become more significant, I'm very open to make a decent version bump and proper release - let's try to not forget that.

@angelina-momin angelina-momin merged commit cb2287f into codecheckers:master May 13, 2024
4 checks passed
@angelina-momin angelina-momin deleted the refactor_render_register_file branch June 19, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants