-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor render register file #38
Refactor render register file #38
Conversation
@nuest I cannot add anyone as reviewer so I am tagging you here to ask for a review. |
Hi @angelina-momin ! Changes look good to me, only one more thing: Can you please bump the development version to Once you changes become more significant, I'm very open to make a decent version bump and proper release - let's try to not forget that. |
Made the following changes:
register.R
utils_preprocess_register.R
utils_render_register.R
utils_register_check.R
DESCRIPTION
fileDESCRIPTION
fileR-CMD-check.yaml
to use r-lib's v2-branch instead of master branch. Otherwise the workflow runs fail. The "master" branch was replaced with "v2-branch"Already tested it out by running the function and checking the results and it looks good.