Skip to content

Commit

Permalink
improve coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
giovanni-guidini committed Dec 14, 2023
1 parent 18f353e commit 8fbd52e
Show file tree
Hide file tree
Showing 2 changed files with 78 additions and 0 deletions.
41 changes: 41 additions & 0 deletions tests/helpers/test_upload_sender.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,47 @@ def test_upload_sender_post_called_with_right_parameters(
post_req_made.headers.items() >= headers.items()
) # test dict is a subset of the other

def test_upload_sender_post_called_with_right_parameters_tokenless(
self,
mocked_responses,
mocked_legacy_upload_endpoint,
mocked_storage_server,
mocker,
):
headers = {"X-Tokenless": "user-forked/repo", "X-Tokenless-PR": "pr"}
mock_get_pull = mocker.patch(
"codecov_cli.services.upload.upload_sender.get_pull",
return_value={
"head": {"slug": "user-forked/repo"},
"base": {"slug": "org/repo"},
},
)
mocked_legacy_upload_endpoint.match = [
matchers.json_params_matcher(request_data),
matchers.header_matcher(headers),
]

sending_result = UploadSender().send_upload_data(
upload_collection, random_sha, None, **named_upload_data
)
assert sending_result.error is None
assert sending_result.warnings == []

assert len(mocked_responses.calls) == 2

post_req_made = mocked_responses.calls[0].request
encoded_slug = encode_slug(named_upload_data["slug"])
response = json.loads(mocked_responses.calls[0].response.text)
assert response.get("url") == "https://app.codecov.io/commit-url"
assert (
post_req_made.url
== f"https://api.codecov.io/upload/github/{encoded_slug}/commits/{random_sha}/reports/{named_upload_data['report_code']}/uploads"
)
assert (
post_req_made.headers.items() >= headers.items()
) # test dict is a subset of the other
mock_get_pull.assert_called()

def test_upload_sender_put_called_with_right_parameters(
self, mocked_responses, mocked_legacy_upload_endpoint, mocked_storage_server
):
Expand Down
37 changes: 37 additions & 0 deletions tests/services/report/test_report_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,43 @@ def test_send_create_report_request_200(mocker):
mocked_response.assert_called_once()


def test_send_create_report_request_200_tokneless(mocker):
mocked_response = mocker.patch(
"codecov_cli.services.report.send_post_request",
return_value=RequestResult(
status_code=200,
error=None,
warnings=[],
text="mocked response",
),
)

mocked_get_pull = mocker.patch(
"codecov_cli.services.report.get_pull",
return_value={
"head": {"slug": "user-forked/repo"},
"base": {"slug": "org/repo"},
},
)
res = send_create_report_request(
"commit_sha",
"code",
"github",
None,
"owner::::repo",
"enterprise_url",
1,
)
assert res.error is None
assert res.warnings == []
mocked_response.assert_called_with(
url=f"enterprise_url/upload/github/owner::::repo/commits/commit_sha/reports",
headers={"X-Tokenless": "user-forked/repo", "X-Tokenless-PR": 1},
data={"code": "code"},
)
mocked_get_pull.assert_called()


def test_send_create_report_request_403(mocker):
mocked_response = mocker.patch(
"codecov_cli.services.report.requests.post",
Expand Down

0 comments on commit 8fbd52e

Please sign in to comment.