fix: Try to fix httpx.PoolTimeout error #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to limit the httpx.PoolTimeout errors when uploading code. Fingers crossed the default limits work better for us. Let it be known that we don't know why the limits were chosen, so we are essentially winging it at this point.
giovanni-guidini
requested review from
scott-codecov,
joseph-sentry and
matt-codecov
Codecov Report
@@ Coverage Diff @@
## main #293 +/- ##
==========================================
- Coverage 95.56% 95.56% -0.01%
==========================================
Files 79 79
Lines 2727 2726 -1
==========================================
- Hits 2606 2605 -1
Misses 121 121
Flags with carried forward coverage won't be shown. Click here to find out more.
|
scott-codecov
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to limit the httpx.PoolTimeout
errors when uploading code.
Fingers crossed the default limits work better for us.
Let it be known that we don't know why the limits were chosen,
so we are essentially winging it at this point.