Create BaseFileFinder and TestingResultFileFinder classes #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality of the CoverageFileFinder class has been moved into the new BaseFileFinder class that the CoverageFileFinder and TestingResultFileFinder inherit from. The goal is to have the two finders share the same functionality for finding files whilst having different default patterns to look for. Signed-off-by: joseph-sentry <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #317 +/- ##
==========================================
- Coverage 95.55% 95.54% -0.02%
==========================================
Files 79 81 +2
Lines 2745 2760 +15
==========================================
+ Hits 2623 2637 +14
- Misses 122 123 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: joseph-sentry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality of the CoverageFileFinder class has been moved into the new BaseFileFinder class that the CoverageFileFinder and TestingResultFileFinder inherit from.
The goal is to have the two finders share the same functionality for finding files whilst having different default patterns to look for.