add X-Tokenless header when uploading from fork #334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* heads/main: simplify the ternary operator amend branch names to be forked-slug:branch-name we need the pr number for the PR API request to know if the command runs in a fork PR chore: Fix helper text in label analysis (#315) taking decoding slug out of is_fork_pr, cause it doesn't feel right to be there adding tests check if the PR is a fork PR chore: remove smart-open (#326)
Allow JWT tokens
|
Ops messed up the branches. Sorry 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public forks will accept tokenless uploads.
Currently we were just sending an empty header (no Authorization).
These changes add a header
X-Tokenless: fork_slugso we knoweasily that the request is from a fork, and which fork it's from.
I also have a tendency to compulsively add typehints to complex
types.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.