-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upload test results #363
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 81 81
Lines 2816 2816
=======================================
Hits 2704 2704
Misses 112 112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a5e5680
to
b61afad
Compare
ac9d79c
to
2ce7ae9
Compare
Signed-off-by: joseph-sentry <[email protected]>
2ce7ae9
to
4b82d8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to see this in ours repos! o/
@@ -76,11 +76,12 @@ jobs: | |||
pip install -r tests/requirements.txt | |||
- name: Test with pytest | |||
run: | | |||
pytest --cov | |||
pytest --cov --junitxml=junit.xml | |||
- name: Dogfooding codecov-cli | |||
if: ${{ !github.event.pull_request.head.repo.fork && github.repository_owner == 'codecov' }} | |||
run: | | |||
codecovcli do-upload --fail-on-error -t ${{ secrets.CODECOV_TOKEN }} --plugin pycoverage --flag python${{matrix.python-version}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a stupid question, but for my own understanding, do we expect that the regular upload will also include the test result file (and won't find a parser for it and then will fail) or it's not even picked up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might add it to the coverage uploads but there should not be a parser for it.
Currrent settings are that the coverage file finder will not ignore files if they have "junit" in the name source
Uploads test results to codecov