Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upload test results #363

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Jan 29, 2024

Uploads test results to codecov

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d309ec) 96.02% compared to head (4b82d8d) 96.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #363   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files          81       81           
  Lines        2816     2816           
=======================================
  Hits         2704     2704           
  Misses        112      112           
Flag Coverage Δ
python3.10 96.31% <ø> (ø)
python3.11 96.30% <ø> (ø)
python3.8 96.27% <ø> (ø)
python3.9 96.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry marked this pull request as ready for review February 2, 2024 23:26
@joseph-sentry joseph-sentry force-pushed the joseph/upload-test-results branch from a5e5680 to b61afad Compare February 2, 2024 23:26
adrian-codecov
adrian-codecov previously approved these changes Feb 5, 2024
@joseph-sentry joseph-sentry force-pushed the joseph/upload-test-results branch 2 times, most recently from ac9d79c to 2ce7ae9 Compare February 7, 2024 22:44
Signed-off-by: joseph-sentry <[email protected]>
Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see this in ours repos! o/

@@ -76,11 +76,12 @@ jobs:
pip install -r tests/requirements.txt
- name: Test with pytest
run: |
pytest --cov
pytest --cov --junitxml=junit.xml
- name: Dogfooding codecov-cli
if: ${{ !github.event.pull_request.head.repo.fork && github.repository_owner == 'codecov' }}
run: |
codecovcli do-upload --fail-on-error -t ${{ secrets.CODECOV_TOKEN }} --plugin pycoverage --flag python${{matrix.python-version}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a stupid question, but for my own understanding, do we expect that the regular upload will also include the test result file (and won't find a parser for it and then will fail) or it's not even picked up?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might add it to the coverage uploads but there should not be a parser for it.

Currrent settings are that the coverage file finder will not ignore files if they have "junit" in the name source

@joseph-sentry joseph-sentry merged commit 52642a0 into main Feb 8, 2024
17 of 18 checks passed
@joseph-sentry joseph-sentry deleted the joseph/upload-test-results branch February 8, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants