Fix compatibility on non-git project folders when git is installed on the system

[jamie]

Hi, I'm not a python person so not sure best way to add test coverage for this, but to kick off a discussion here's the code change.

We run our CI through Jenkins, and to support job fanout our build process involves doing a git checkout on one node, caching the application files, and then subsequent nodes will restore code from that cache and run a subset of our tests. (We currently have a job fanout of around 50.) To reduce the size of the cached blob, we are excluding our .git folder from the cache.

This leads to us hitting a problem uploading our coverage files, because the GitVersioningSystem:

• says it is_available if git is installed on the system (which it is because we reuse our worker base images)
• in get_network_root it fails because git rev-parse --show-toplevel is erroring out fatal: not a git repository
• in list_relevant_files it therefore raises Can't determine root folder and blows up the stack:

<snip>
  File "/home/deploy/.local/lib/python3.7/site-packages/codecov_cli/commands/upload.py", line 256, in do_upload
    handle_no_reports_found=handle_no_reports_found,
  File "/home/deploy/.local/lib/python3.7/site-packages/codecov_cli/services/upload/__init__.py", line 66, in do_upload_logic
    upload_data = collector.generate_upload_data()
  File "/home/deploy/.local/lib/python3.7/site-packages/codecov_cli/services/upload/upload_collector.py", line 145, in generate_upload_data
    network = self.network_finder.find_files()
  File "/home/deploy/.local/lib/python3.7/site-packages/codecov_cli/services/upload/network_finder.py", line 17, in find_files
    return self.versioning_system.list_relevant_files(network_root)
  File "/home/deploy/.local/lib/python3.7/site-packages/codecov_cli/helpers/versioning_systems.py", line 111, in list_relevant_files
    raise ValueError("Can't determine root folder")
ValueError: Can't determine root folder

I'm Patching It Live (thanks for the perl oneliner help, ChatGPT) to get it working for us, and can confirm that this change does successfully prevent GitVersioningSystem from being used, and NoVersioningSystem is treating us fine with just the Path.cwd() check.

[joseph-sentry]

Hi @jamie, thanks for opening this PR and for the thorough explanation of the problem!

These changes look good to me.

It looks like the linting step in the CI failed, you can get rid of that by running make lint and pushing those changes.

[jamie]

@joseph-sentry Cleaned this up.

[joseph-sentry]

This repo requires commits to be signed :(

my preferred way of retroactively signing commits (source):

git rebase --exec 'git commit --amend --no-edit -n -S' <ref of commit until which you want to sign>

this may require a force push to the branch

[jamie]

👍 Signed