Remove token enforcement for true tokenless endpoints #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #533 +/- ##
=======================================
Coverage 95.95% 95.95%
=======================================
Files 84 84
Lines 3067 3067
=======================================
Hits 2943 2943
Misses 124 124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
|
Agreed, this looks good to me. I'd like to know, however, that this change has been tested on
|
nora-codecov
force-pushed
the
nora/2298
branch
from
49b978f to
d0eab69
Compare
thomasrockhu-codecov
previously approved these changes
Nov 7, 2024
thomasrockhu-codecov
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went through the upload endpoints on API:
endpoints where we want to allow tokenless: I've made sure the method uses
get_token_header()which allowsNonefor thetoken, which will allow tokenless requests through to the api.endpoints where we don't want to allow tokenless: I've made sure they use
get_token_header_or_fail()which does not allowNone, so the request will be kicked out before it gets to api. This is not required for the tokenless logic to work, but is nice to have since it prevents junk requests from clogging api.update: we are going to allow tokenless uploads on all upload related endpoints, so switched them all to
get_token_header().get_token_header_or_fail()is now unused, but I'm leaving it in code for if we need to switch an endpoint back to token required.codecov/engineering-team#2300