Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import error #567

Merged
merged 6 commits into from
Nov 26, 2024
Merged

fix: import error #567

merged 6 commits into from
Nov 26, 2024

Conversation

joseph-sentry
Copy link
Contributor

this PR fixes an import error in get_report_results.py and also fixes a bunch of linting errors ruff brings up

@joseph-sentry joseph-sentry requested a review from a team November 25, 2024 15:21
Copy link

codecov bot commented Nov 25, 2024

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
3550 5 3545 0
View the top 3 failed tests by shortest run time
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

this uses ruff for linting, it adds a configuration for ignoring
certain rules (F401: unused import) and excluding certain directories
(default + languages/ + samples/)
@@ -141,7 +141,7 @@ def _get_file_fixes(
reason=err.reason,
),
)
except IsADirectoryError as err:
except IsADirectoryError as _:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] in a previous instance the as _ was completely removed

@joseph-sentry joseph-sentry merged commit c20a203 into main Nov 26, 2024
18 of 19 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-stuff branch November 26, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants