Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the last release attempt, maturin
v1.7.2
came out which has a regression that impacts us. also i missed a windows issue (apparently my windows env doesn't haveautocrlf
enabled). this PR fixes both issuesi tested by adding a
pull_request
trigger which i've now removed. here's a run where everything passed https://github.com/codecov/codecov-rs/actions/runs/11041921939a full recounting of release problems:
maturin generate-ci github --pytest
: non-x86 architectures stuck on Python 3.10 for pytest PyO3/maturin#2227.gitattributes
(apparently my windows env didn't have this enabled)libgcc_s.so
due to incorrectRPATH
in musllinux wheel PyO3/maturin#2232