Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate benchmarks to criterion and setup codspeed #60

Open
wants to merge 1 commit into
base: swatinem/update-ci
Choose a base branch
from

Conversation

Swatinem
Copy link
Collaborator

This migrates the pyreport benchmarks to criterion via the codspeed compatibility layer. Additionally, this also creates a CI job to run the benchmarks within the codspeed runner, and upload the results.

@Swatinem Swatinem self-assigned this Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.52%. Comparing base (ae5e39d) to head (54cbaa6).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           swatinem/update-ci      #60   +/-   ##
===================================================
  Coverage               98.52%   98.52%           
===================================================
  Files                      21       21           
  Lines                    6772     6772           
===================================================
  Hits                     6672     6672           
  Misses                    100      100           
Components Coverage Δ
core 98.60% <ø> (ø)
bindings 79.31% <ø> (ø)
python 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This migrates the pyreport benchmarks to `criterion` via the codspeed compatibility layer.
Additionally, this also creates a CI job to run the benchmarks within the codspeed runner, and upload the results.
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 4 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • complex_chunks (13.9 s)
  • complex_report_json (98.4 ms)
  • simple_chunks (62.1 µs)
  • simple_report_json (32.1 µs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants