Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove enterprise cloud support plan flag #3506

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Nov 15, 2024

Description

This PR aims to remove the enterprise cloud support plan flag, and subsequently the ability to "find" the enterprise plans when upgrading to a pro plan

Launch Darkly link: https://app.launchdarkly.com/projects/dashboard/flags/enterprise-cloud-plan-support/targeting?env=test&env=production&selected-env=production

Interestingly we default the flag state to true, but the flag is off and has been off since June 2022

Closes #2936

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Nov 15, 2024

Bundle Report

Changes will decrease total bundle size by 1.11kB (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.63MB 441 bytes (-0.01%) ⬇️
gazebo-staging-system 5.58MB 669 bytes (-0.01%) ⬇️

Copy link

codecov bot commented Nov 15, 2024

Bundle Report

Changes will decrease total bundle size by 1.11kB (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.58MB 669 bytes (-0.01%) ⬇️
gazebo-production-system-esm 5.63MB 441 bytes (-0.01%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (ba74572) to head (29f9040).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3506      +/-   ##
==========================================
- Coverage   98.91%   98.91%   -0.01%     
==========================================
  Files         808      806       -2     
  Lines       14458    14437      -21     
  Branches     4110     4094      -16     
==========================================
- Hits        14301    14280      -21     
  Misses        150      150              
  Partials        7        7              
Files with missing lines Coverage Δ
src/shared/utils/billing.ts 98.05% <100.00%> (-0.13%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.58% <ø> (-0.01%) ⬇️
Services 99.33% <ø> (ø)
Shared 99.33% <100.00%> (-0.01%) ⬇️
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba74572...29f9040. Read the comment docs.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (ba74572) to head (29f9040).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3506      +/-   ##
==========================================
- Coverage   98.91%   98.91%   -0.01%     
==========================================
  Files         808      806       -2     
  Lines       14458    14437      -21     
  Branches     4117     4101      -16     
==========================================
- Hits        14301    14280      -21     
  Misses        150      150              
  Partials        7        7              
Files with missing lines Coverage Δ
src/shared/utils/billing.ts 98.05% <100.00%> (-0.13%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.58% <ø> (-0.01%) ⬇️
Services 99.33% <ø> (ø)
Shared 99.33% <100.00%> (-0.01%) ⬇️
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba74572...29f9040. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3506      +/-   ##
==========================================
- Coverage   98.91%   98.91%   -0.01%     
==========================================
  Files         808      806       -2     
  Lines       14458    14437      -21     
  Branches     4110     4101       -9     
==========================================
- Hits        14301    14280      -21     
  Misses        150      150              
  Partials        7        7              
Files with missing lines Coverage Δ
src/shared/utils/billing.ts 98.05% <100.00%> (-0.13%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.58% <ø> (-0.01%) ⬇️
Services 99.33% <ø> (ø)
Shared 99.33% <100.00%> (-0.01%) ⬇️
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba74572...29f9040. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Nov 15, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
f11f13d Fri, 15 Nov 2024 23:18:28 GMT Expired Expired
ae716f6 Tue, 26 Nov 2024 00:45:11 GMT Expired Expired
9ff53fe Tue, 26 Nov 2024 18:40:02 GMT Expired Expired
29f9040 Wed, 27 Nov 2024 23:37:05 GMT Cloud Enterprise

@calvin-codecov calvin-codecov added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@calvin-codecov calvin-codecov added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@calvin-codecov calvin-codecov added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@calvin-codecov calvin-codecov added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit b2c5487 Nov 27, 2024
61 of 62 checks passed
@calvin-codecov calvin-codecov deleted the Ajay/remove-enterprise-cloud-plan-support-flag branch November 27, 2024 23:39
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (ba74572) to head (29f9040).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3506      +/-   ##
==========================================
- Coverage   98.91%   98.91%   -0.01%     
==========================================
  Files         808      806       -2     
  Lines       14458    14437      -21     
  Branches     4117     4094      -23     
==========================================
- Hits        14301    14280      -21     
  Misses        150      150              
  Partials        7        7              
Files with missing lines Coverage Δ
src/shared/utils/billing.ts 98.05% <100.00%> (-0.13%) ⬇️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.58% <ø> (-0.01%) ⬇️
Services 99.33% <ø> (ø)
Shared 99.33% <100.00%> (-0.01%) ⬇️
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba74572...29f9040. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Enterprise cloud plan support LD Flag
4 participants