Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate useComponentComparison to TS Query V5 #3539

Merged
merged 2 commits into from
Dec 3, 2024
Merged

chore: Migrate useComponentComparison to TS Query V5 #3539

merged 2 commits into from
Dec 3, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR migrates the useComponentComparison to ComponentComparisonQueryOpts utilizing Query V5's queryOptions API.

Ticket: codecov/engineering-team#2965

Notable Changes

  • Migrate useComponentComparison to ComponentComparisonQueryOpts
  • Update ComponentsTable to use new Query Options
  • Update/Cleanup Tests
    • Unrelated: added missing MSW mock

@codecov-staging
Copy link

codecov-staging bot commented Nov 29, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 793 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.73MB 298 bytes (0.01%) ⬆️
gazebo-staging-system 5.68MB 495 bytes (0.01%) ⬆️

@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 793 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.68MB 495 bytes (0.01%) ⬆️
gazebo-production-system-esm 5.73MB 298 bytes (0.01%) ⬆️

@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (67b950a) to head (52cfd83).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3539   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         806      805    -1     
  Lines       14447    14447           
  Branches     4098     4097    -1     
=======================================
  Hits        14291    14291           
  Misses        149      149           
  Partials        7        7
Files with missing lines Coverage Δ
...lCoverage/routes/ComponentsTab/ComponentsTable.tsx 100.00% <100.00%> (ø)
...onentsTab/queries/ComponentComparisonQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b950a...52cfd83. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3539   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         806      805    -1     
  Lines       14447    14447           
  Branches     4105     4097    -8     
=======================================
  Hits        14291    14291           
  Misses        149      149           
  Partials        7        7
Files with missing lines Coverage Δ
...lCoverage/routes/ComponentsTab/ComponentsTable.tsx 100.00% <100.00%> (ø)
...onentsTab/queries/ComponentComparisonQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b950a...52cfd83. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (67b950a) to head (52cfd83).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3539   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         806      805    -1     
  Lines       14447    14447           
  Branches     4098     4097    -1     
=======================================
  Hits        14291    14291           
  Misses        149      149           
  Partials        7        7
Files with missing lines Coverage Δ
...lCoverage/routes/ComponentsTab/ComponentsTable.tsx 100.00% <100.00%> (ø)
...onentsTab/queries/ComponentComparisonQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b950a...52cfd83. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
52cfd83 Fri, 29 Nov 2024 13:31:28 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit d4d8342 Dec 3, 2024
59 of 62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-2965-chore-migrate-useComponentComparison-to-tsqv5 branch December 3, 2024 11:37
@codecov-public-qa Codecov Public QA
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.92%. Comparing base (67b950a) to head (52cfd83).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3539   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         806      805    -1     
  Lines       14447    14447           
  Branches     4098     4104    +6     
=======================================
  Hits        14291    14291           
  Misses        149      149           
  Partials        7        7
Files with missing lines Coverage Δ
...lCoverage/routes/ComponentsTab/ComponentsTable.tsx 100.00% <100.00%> (ø)
...onentsTab/queries/ComponentComparisonQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.59% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.21% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b950a...52cfd83. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suejung-sentry suejung-sentry suejung-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-codecov @codecov-releaser @suejung-sentry