chore: Migrate useIgnoredIds to TS Query V5 #3547

nicholas-codecov · 2024-12-03T17:20:51Z

Description

This PR migrates the useIgnoredIds hook over to the query options API to IgnoredIdsQueryOptions

Ticket: codecov/engineering-team#2966

Notable Changes

Migrate useIgnoredIds to IgnoredIdsQueryOptions
Create/Update tests

codecov-staging · 2024-12-03T17:23:38Z

Bundle Report

Changes will increase total bundle size by 1.36kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-system-esm	5.72MB	599 bytes (0.01%) ⬆️
gazebo-staging-system	5.67MB	763 bytes (0.01%) ⬆️

codecov-notifications · 2024-12-03T17:24:43Z

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	92.30%	1 Missing ⚠️

@@           Coverage Diff           @@
##             main    #3547   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14476    14484    +8     
  Branches     4108     4118   +10     
=======================================
+ Hits        14318    14326    +8     
  Misses        151      151           
  Partials        7        7

Files with missing lines	Coverage Δ
...tailPage/CommitCoverage/UploadsCard/UploadItem.tsx	`100.00% <100.00%> (ø)`
...hangedTab/shared/CommitFileDiff/CommitFileDiff.tsx	`97.61% <100.00%> (ø)`
...rectChangesTable/CommitFileDiff/CommitFileDiff.tsx	`97.67% <100.00%> (ø)`
src/pages/CommitDetailPage/CommitDetailPage.tsx	`100.00% <100.00%> (ø)`
...CommitDetailPage/queries/IgnoredIdsQueryOptions.ts	`100.00% <100.00%> (ø)`
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	`97.93% <92.30%> (+0.21%)`	⬆️

... and 26 files with indirect coverage changes

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.59% <95.45%> (+<0.01%)`	⬆️
Services	`99.33% <ø> (ø)`
Shared	`99.33% <ø> (+<0.01%)`	⬆️
UI	`99.14% <ø> (-0.01%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77d790...c64ce66. Read the comment docs.

codecov-qa · 2024-12-03T17:24:43Z

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.90%. Comparing base (a77d790) to head (c64ce66).
Report is 12 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	92.30%	1 Missing ⚠️

@@           Coverage Diff           @@
##             main    #3547   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14476    14484    +8     
  Branches     4115     4118    +3     
=======================================
+ Hits        14318    14326    +8     
  Misses        151      151           
  Partials        7        7

Files with missing lines	Coverage Δ
...tailPage/CommitCoverage/UploadsCard/UploadItem.tsx	`100.00% <100.00%> (ø)`
...hangedTab/shared/CommitFileDiff/CommitFileDiff.tsx	`97.61% <100.00%> (ø)`
...rectChangesTable/CommitFileDiff/CommitFileDiff.tsx	`97.67% <100.00%> (ø)`
src/pages/CommitDetailPage/CommitDetailPage.tsx	`100.00% <100.00%> (ø)`
...CommitDetailPage/queries/IgnoredIdsQueryOptions.ts	`100.00% <100.00%> (ø)`
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	`97.93% <92.30%> (+0.21%)`	⬆️

... and 26 files with indirect coverage changes

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.59% <95.45%> (+<0.01%)`	⬆️
Services	`99.33% <ø> (ø)`
Shared	`99.33% <ø> (+<0.01%)`	⬆️
UI	`99.14% <ø> (-0.01%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77d790...c64ce66. Read the comment docs.

codecov-releaser · 2024-12-03T17:27:42Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`06d29e5`	Tue, 03 Dec 2024 17:27:42 GMT	Expired	Expired
`49a08d5`	Fri, 06 Dec 2024 18:26:41 GMT	Expired	Expired
`c64ce66`	Fri, 06 Dec 2024 18:49:14 GMT	Cloud	Enterprise

codecov · 2024-12-03T18:19:58Z

Bundle Report

Changes will increase total bundle size by 1.36kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-system	5.67MB	763 bytes (0.01%) ⬆️
gazebo-production-system-esm	5.72MB	599 bytes (0.01%) ⬆️

codecov · 2024-12-03T18:41:04Z

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.90%. Comparing base (a77d790) to head (c64ce66).
Report is 12 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	92.30%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3547   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14476    14484    +8     
  Branches     4115     4111    -4     
=======================================
+ Hits        14318    14326    +8     
  Misses        151      151           
  Partials        7        7

Files with missing lines	Coverage Δ
...tailPage/CommitCoverage/UploadsCard/UploadItem.tsx	`100.00% <100.00%> (ø)`
...hangedTab/shared/CommitFileDiff/CommitFileDiff.tsx	`97.61% <100.00%> (ø)`
...rectChangesTable/CommitFileDiff/CommitFileDiff.tsx	`97.67% <100.00%> (ø)`
src/pages/CommitDetailPage/CommitDetailPage.tsx	`100.00% <100.00%> (ø)`
...CommitDetailPage/queries/IgnoredIdsQueryOptions.ts	`100.00% <100.00%> (ø)`
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	`97.93% <92.30%> (+0.21%)`	⬆️

... and 26 files with indirect coverage changes

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.59% <95.45%> (+<0.01%)`	⬆️
Services	`99.33% <ø> (ø)`
Shared	`99.33% <ø> (+<0.01%)`	⬆️
UI	`99.14% <ø> (-0.01%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77d790...c64ce66. Read the comment docs.

codecov-public-qa · 2024-12-09T13:59:22Z

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.90%. Comparing base (a77d790) to head (c64ce66).
Report is 12 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	92.30%	1 Missing ⚠️

@@           Coverage Diff           @@
##             main    #3547   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14476    14484    +8     
  Branches     4115     4111    -4     
=======================================
+ Hits        14318    14326    +8     
  Misses        151      151           
  Partials        7        7

Files with missing lines	Coverage Δ
...tailPage/CommitCoverage/UploadsCard/UploadItem.tsx	`100.00% <100.00%> (ø)`
...hangedTab/shared/CommitFileDiff/CommitFileDiff.tsx	`97.61% <100.00%> (ø)`
...rectChangesTable/CommitFileDiff/CommitFileDiff.tsx	`97.67% <100.00%> (ø)`
src/pages/CommitDetailPage/CommitDetailPage.tsx	`100.00% <100.00%> (ø)`
...CommitDetailPage/queries/IgnoredIdsQueryOptions.ts	`100.00% <100.00%> (ø)`
...ailPage/CommitCoverage/UploadsCard/UploadsCard.tsx	`97.93% <92.30%> (+0.21%)`	⬆️

... and 26 files with indirect coverage changes

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.59% <95.45%> (+<0.01%)`	⬆️
Services	`99.33% <ø> (ø)`
Shared	`99.33% <ø> (+<0.01%)`	⬆️
UI	`99.14% <ø> (-0.01%)`	⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77d790...c64ce66. Read the comment docs.

nicholas-codecov added 2 commits December 3, 2024 13:17

migrate useIgnoredIds to TS Query V5

a01fee3

update components and their tests using this migrated hook

06d29e5

suejung-sentry approved these changes Dec 6, 2024

View reviewed changes

nicholas-codecov added 2 commits December 6, 2024 14:20

resolve issue where click checkboxes doesn't update the query cache

49a08d5

get all selector working as well

c64ce66

rohitvinnakota-codecov approved these changes Dec 6, 2024

View reviewed changes

suejung-sentry approved these changes Dec 6, 2024

View reviewed changes

nicholas-codecov added this pull request to the merge queue Dec 6, 2024

nicholas-codecov removed this pull request from the merge queue due to a manual request Dec 6, 2024

nicholas-codecov added this pull request to the merge queue Dec 9, 2024

Merged via the queue into main with commit b4e0043 Dec 9, 2024
53 of 62 checks passed

nicholas-codecov deleted the gh-eng-2966-chore-migrate-useIgnoreIds-to-tsqv5 branch December 9, 2024 13:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Migrate useIgnoredIds to TS Query V5 #3547

chore: Migrate useIgnoredIds to TS Query V5 #3547

nicholas-codecov commented Dec 3, 2024

codecov-staging bot commented Dec 3, 2024 •

edited

Loading

codecov-notifications bot commented Dec 3, 2024 •

edited

Loading

codecov-qa bot commented Dec 3, 2024 •

edited

Loading

codecov-releaser commented Dec 3, 2024 •

edited

Loading

codecov bot commented Dec 3, 2024 •

edited

Loading

codecov bot commented Dec 3, 2024 •

edited

Loading

codecov-public-qa bot commented Dec 9, 2024

chore: Migrate useIgnoredIds to TS Query V5 #3547

chore: Migrate useIgnoredIds to TS Query V5 #3547

Conversation

nicholas-codecov commented Dec 3, 2024

Description

Notable Changes

codecov-staging bot commented Dec 3, 2024 • edited Loading

Bundle Report

codecov-notifications bot commented Dec 3, 2024 • edited Loading

Codecov Report

codecov-qa bot commented Dec 3, 2024 • edited Loading

Codecov Report

codecov-releaser commented Dec 3, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

codecov bot commented Dec 3, 2024 • edited Loading

Bundle Report

codecov bot commented Dec 3, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Dec 9, 2024

Codecov Report

codecov-staging bot commented Dec 3, 2024 •

edited

Loading

codecov-notifications bot commented Dec 3, 2024 •

edited

Loading

codecov-qa bot commented Dec 3, 2024 •

edited

Loading

codecov-releaser commented Dec 3, 2024 •

edited

Loading

codecov bot commented Dec 3, 2024 •

edited

Loading

codecov bot commented Dec 3, 2024 •

edited

Loading