Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate useCommitHeaderDataTeam to TS Query V5 #3549

Merged
merged 2 commits into from
Dec 6, 2024
Merged

chore: Migrate useCommitHeaderDataTeam to TS Query V5 #3549

merged 2 commits into from
Dec 6, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR migrates the useCommitHeaderDataTeam to the query options API version CommitHeaderDataTeamQueryOpts

Ticket: codecov/engineering-team#2966

Notable Changes

  • Migrate useCommitHeaderDataTeam to CommitHeaderDataTeamQueryOpts
  • Update tests

@codecov-staging
Copy link

codecov-staging bot commented Dec 3, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 739 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 5.72MB 332 bytes (0.01%) ⬆️
gazebo-staging-system 5.67MB 407 bytes (0.01%) ⬆️

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3549   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14476    14476           
  Branches     4108     4108           
=======================================
  Hits        14318    14318           
  Misses        151      151           
  Partials        7        7
Files with missing lines Coverage Δ
.../CommitDetailPage/Header/HeaderTeam/HeaderTeam.jsx 100.00% <100.00%> (ø)
...aderTeam/queries/CommitHeaderDataTeamQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77d790...12c0e8f. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (a77d790) to head (12c0e8f).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3549   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14476    14476           
  Branches     4115     4108    -7     
=======================================
  Hits        14318    14318           
  Misses        151      151           
  Partials        7        7
Files with missing lines Coverage Δ
.../CommitDetailPage/Header/HeaderTeam/HeaderTeam.jsx 100.00% <100.00%> (ø)
...aderTeam/queries/CommitHeaderDataTeamQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77d790...12c0e8f. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
12c0e8f Tue, 03 Dec 2024 17:44:45 GMT Cloud Enterprise

@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024

Bundle Report

Changes will increase total bundle size by 739 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 5.67MB 407 bytes (0.01%) ⬆️
gazebo-production-system-esm 5.72MB 332 bytes (0.01%) ⬆️

@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (a77d790) to head (12c0e8f).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3549   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14476    14476           
  Branches     4115     4115           
=======================================
  Hits        14318    14318           
  Misses        151      151           
  Partials        7        7
Files with missing lines Coverage Δ
.../CommitDetailPage/Header/HeaderTeam/HeaderTeam.jsx 100.00% <100.00%> (ø)
...aderTeam/queries/CommitHeaderDataTeamQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77d790...12c0e8f. Read the comment docs.

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 729b0ce Dec 6, 2024
59 of 62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-2966-chore-migrate-useCommitHeaderDataTeam-to-tsqv5 branch December 6, 2024 18:43
@codecov-public-qa Codecov Public QA
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.90%. Comparing base (a77d790) to head (12c0e8f).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3549   +/-   ##
=======================================
  Coverage   98.90%   98.90%           
=======================================
  Files         806      806           
  Lines       14476    14476           
  Branches     4115     4115           
=======================================
  Hits        14318    14318           
  Misses        151      151           
  Partials        7        7
Files with missing lines Coverage Δ
.../CommitDetailPage/Header/HeaderTeam/HeaderTeam.jsx 100.00% <100.00%> (ø)
...aderTeam/queries/CommitHeaderDataTeamQueryOpts.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.59% <100.00%> (ø)
Services 99.33% <ø> (ø)
Shared 99.33% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a77d790...12c0e8f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suejung-sentry suejung-sentry suejung-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-codecov @codecov-releaser @suejung-sentry