Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Copy when changing plan from free plan #3594

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix: Copy when changing plan from free plan #3594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/UpdateBlurb/UpdateBlurb.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,15 +115,15 @@ describe('UpdateBlurb', () => {
const seatsBlurb = await screen.findByText(
'You are changing seats from 2 to [10]'
)
const billingBlurb = await screen.findByText(
const billingBlurb = screen.queryByText(
'You are changing your billing cycle from Monthly to [Annual]'
)
const immediateUpdate = await screen.findByText(
/Your changes will take effect immediately./
)
expect(planBlurb).toBeInTheDocument()
expect(seatsBlurb).toBeInTheDocument()
expect(billingBlurb).toBeInTheDocument()
expect(billingBlurb).not.toBeInTheDocument()
expect(immediateUpdate).toBeInTheDocument()
})
})
Expand Down
2 changes: 1 addition & 1 deletion src/pages/PlanPage/subRoutes/UpgradePlanPage/UpgradeForm/UpdateBlurb/UpdateBlurb.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const UpdateBlurb = ({
{diffSeats && (
<li className="pl-2">{`You are changing seats from ${currentPlan?.planUserCount} to [${seats}]`}</li>
)}
{diffBillingType && (
{diffBillingType && !currentIsFree && (
<li className="pl-2">{`You are changing your billing cycle from ${
currentIsAnnual ? 'Annual' : 'Monthly'
} to [${currentIsAnnual ? 'Monthly' : 'Annual'}]`}</li>
Expand Down
Loading