Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove new repo flag in LD #3651

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Conversation

ajay-sentry
Copy link
Contributor

Description

This PR removes the new repo flag which has been on in LD at 100% since Feb 2024. Safe to say it's probably good to remove at this point; also had to update a few tests in the process.

Flag in LD

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Jan 11, 2025

Bundle Report

Changes will decrease total bundle size by 631 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.04MB 319 bytes (-0.01%) ⬇️
gazebo-staging-esm 6.09MB 312 bytes (-0.01%) ⬇️

Copy link

codecov bot commented Jan 11, 2025

Bundle Report

Changes will decrease total bundle size by 631 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.04MB 319 bytes (-0.01%) ⬇️
gazebo-production-esm 6.09MB 312 bytes (-0.01%) ⬇️

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3651      +/-   ##
==========================================
- Coverage   98.94%   98.93%   -0.02%     
==========================================
  Files         813      813              
  Lines       14600    14593       -7     
  Branches     4141     4140       -1     
==========================================
- Hits        14446    14437       -9     
- Misses        147      149       +2     
  Partials        7        7              
Files with missing lines Coverage Δ
.../RepoPage/CoverageOnboarding/CircleCI/CircleCI.tsx 92.30% <ø> (-0.29%) ⬇️
...CoverageOnboarding/GitHubActions/GitHubActions.tsx 95.65% <ø> (-4.35%) ⬇️
...age/CoverageOnboarding/GitHubActions/TokenStep.tsx 96.00% <ø> (-0.16%) ⬇️
...verageOnboarding/GitHubActions/WorkflowYMLStep.tsx 80.00% <ø> (-10.91%) ⬇️
...es/RepoPage/CoverageOnboarding/OtherCI/OtherCI.tsx 100.00% <ø> (ø)
src/services/orgUploadToken/useOrgUploadToken.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.64% <ø> (-0.03%) ⬇️
Services 99.34% <100.00%> (-0.01%) ⬇️
Shared 99.30% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5febc26...11b412e. Read the comment docs.

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (5febc26) to head (11b412e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3651      +/-   ##
==========================================
- Coverage   98.94%   98.93%   -0.02%     
==========================================
  Files         813      813              
  Lines       14600    14593       -7     
  Branches     4148     4140       -8     
==========================================
- Hits        14446    14437       -9     
- Misses        147      149       +2     
  Partials        7        7              
Files with missing lines Coverage Δ
.../RepoPage/CoverageOnboarding/CircleCI/CircleCI.tsx 92.30% <ø> (-0.29%) ⬇️
...CoverageOnboarding/GitHubActions/GitHubActions.tsx 95.65% <ø> (-4.35%) ⬇️
...age/CoverageOnboarding/GitHubActions/TokenStep.tsx 96.00% <ø> (-0.16%) ⬇️
...verageOnboarding/GitHubActions/WorkflowYMLStep.tsx 80.00% <ø> (-10.91%) ⬇️
...es/RepoPage/CoverageOnboarding/OtherCI/OtherCI.tsx 100.00% <ø> (ø)
src/services/orgUploadToken/useOrgUploadToken.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.64% <ø> (-0.03%) ⬇️
Services 99.34% <100.00%> (-0.01%) ⬇️
Shared 99.30% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5febc26...11b412e. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
11b412e Sat, 11 Jan 2025 00:35:41 GMT Cloud Enterprise

@codecov-qa
Copy link

codecov-qa bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (5febc26) to head (11b412e).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3651      +/-   ##
==========================================
- Coverage   98.94%   98.93%   -0.02%     
==========================================
  Files         813      813              
  Lines       14600    14593       -7     
  Branches     4141     4140       -1     
==========================================
- Hits        14446    14437       -9     
- Misses        147      149       +2     
  Partials        7        7              
Files with missing lines Coverage Δ
.../RepoPage/CoverageOnboarding/CircleCI/CircleCI.tsx 92.30% <ø> (-0.29%) ⬇️
...CoverageOnboarding/GitHubActions/GitHubActions.tsx 95.65% <ø> (-4.35%) ⬇️
...age/CoverageOnboarding/GitHubActions/TokenStep.tsx 96.00% <ø> (-0.16%) ⬇️
...verageOnboarding/GitHubActions/WorkflowYMLStep.tsx 80.00% <ø> (-10.91%) ⬇️
...es/RepoPage/CoverageOnboarding/OtherCI/OtherCI.tsx 100.00% <ø> (ø)
src/services/orgUploadToken/useOrgUploadToken.ts 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.64% <ø> (-0.03%) ⬇️
Services 99.34% <100.00%> (-0.01%) ⬇️
Shared 99.30% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5febc26...11b412e. Read the comment docs.

@ajay-sentry ajay-sentry added this pull request to the merge queue Jan 11, 2025
Merged via the queue into main with commit daaed4b Jan 11, 2025
58 of 62 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/remove-new-repo-flag branch January 11, 2025 00:49
@1234336c
Copy link

لقطة الشاشة 2025-01-04 191143

Copy link

@1234336c 1234336c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploading USDT.png…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants