Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove flake detection feature flags #1102

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

joseph-sentry
Copy link
Contributor

this also fixes a test that was previously not working correctly

@joseph-sentry joseph-sentry requested a review from a team February 21, 2025 20:33
Copy link

sentry-io bot commented Feb 21, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: services/test_results.py

Function Unhandled Issue
should_do_flaky_detection Plan.DoesNotExist: Plan matching query does not exist. app.tasks.test_results.TestResultsFinish...
Event Count: 188
should_do_flaky_detection Plan.DoesNotExist: Plan matching query does not exist. app.tasks.pull...
Event Count: 38

Did you find this useful? React with a 👍 or 👎

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.25%. Comparing base (d7b53d8) to head (3eab684).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1102      +/-   ##
==========================================
- Coverage   97.28%   97.25%   -0.03%     
==========================================
  Files         454      454              
  Lines       37355    37327      -28     
==========================================
- Hits        36339    36302      -37     
- Misses       1016     1025       +9     
Flag Coverage Δ
integration 43.12% <83.33%> (-0.03%) ⬇️
unit 89.79% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit f8a8733 Feb 24, 2025
23 of 29 checks passed
@joseph-sentry joseph-sentry deleted the joseph/remove-feature branch February 24, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants