Fixed errors that CI workflow caught #285
Merged
+18
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamFinkle
added a commit
that referenced
this pull request
Jan 22, 2025
commit 2d09a76 Author: Derek McIntire <[email protected]> Date: Tue Jan 21 19:44:27 2025 -0500 Fix tsconfig.json and Lint errors (#290) * fixed all ts errors and lint warnings * Add comments to tsconfig * Don't override includes * add stuff * change target to ES2020 * add exclude list * remove commented out lines * More explicit exclude * try include as well as exclude * Letting claude give it a try * I dont think build is a hidden directory * undo claude * Type check working now * fix eslint comment as well * Add noUncheckedIndexAccess commit ab29024 Author: Derek McIntire <[email protected]> Date: Tue Jan 14 20:42:54 2025 -0500 223 heatload graph (#288) * Use rules engine output to populate heat load graph * update graph record type * run prettier for select files * fix dataKeys * Use correct data and make chart pretty * Graph working, but needs clean up * Clean up and comments * Comments on calculation functions * Add icon, still need to add values underneath chart * restore ws changes to types * Add columns at bottom of chart * Fix reversed average and max in grid * Fix responsiveness issues * Extract utility and data building functions, tool tip and constants * Add comment with link to external calculation docs * Fix tool tip * quick refactor * clean up * refactor calculating min and max for Y axis * set start and end temps once * Add 2f to x axis so tool tip is easier to invoke * review changes to HeatLoad.tsx * All issues except legend and tool type type errors addressed * legend working with valid value for layout * break out legend and fix avg heat load endpoint * Adjust x axis ticks and make design set point a global constant * fix HeatLoadGraphToolTip type error * Remove hard coded data * Add comment to calculateAvgHeatLoadEndPoint * comment out inclusion_override * Fix type errors * re-comment tsconfig commit 98edbe0 Author: AdamFinkle <[email protected]> Date: Mon Dec 16 15:22:38 2024 -0500 Fixed errors that CI workflow caught (#285)
thadk
pushed a commit
that referenced
this pull request
Feb 18, 2025
#299) * Rename directory * Rename rules-engine to python * Co-authored-by: AdamFinkle <[email protected]> Co-authored-by: Deb Debnath <[email protected]> Co-authored-by: stemgene <[email protected]> * Fixed errors that CI workflow caught * Merge branch 'functional_programming' of github.com:stemgene/home-energy-analysis-tool into functional_programming Co-authored-by: stemgene <[email protected]> Co-authored-by: AdamFinkle <[email protected]> * Reworked instructions about how to setup the project. Co-authored-by: stemgene <[email protected]> * Edited setup-python.sh to automatically upgrade pip Co-authored-by: stemgene <[email protected]> * Made _calculate_avg_summer_usage a static method Co-authored-by: stemgene <[email protected]> * Corrected errors caught by mypy Co-authored-by: stemgene <[email protected]> * Corrected an erroneous clause * Moved a block inside _calculate_balance_point_and_ua to before its call. Co-authored-by: Ethan-Strominger <[email protected]> * Moved two variable declarations from inside _calculate_balance_point_and_ua to before its call * Refactored internal object variable assignment to return assignment Co-authored-by: Ethan-Strominger <[email protected]> * Refactored _refine_balance_point to be a static method Co-authored-by: Ethan-Strominger <[email protected]> * Refactored return of _refine_balance_point to be a dictionary Co-authored-by: Ethan-Strominger <[email protected]> * Squashed commit of the following: commit 2d09a76 Author: Derek McIntire <[email protected]> Date: Tue Jan 21 19:44:27 2025 -0500 Fix tsconfig.json and Lint errors (#290) * fixed all ts errors and lint warnings * Add comments to tsconfig * Don't override includes * add stuff * change target to ES2020 * add exclude list * remove commented out lines * More explicit exclude * try include as well as exclude * Letting claude give it a try * I dont think build is a hidden directory * undo claude * Type check working now * fix eslint comment as well * Add noUncheckedIndexAccess commit ab29024 Author: Derek McIntire <[email protected]> Date: Tue Jan 14 20:42:54 2025 -0500 223 heatload graph (#288) * Use rules engine output to populate heat load graph * update graph record type * run prettier for select files * fix dataKeys * Use correct data and make chart pretty * Graph working, but needs clean up * Clean up and comments * Comments on calculation functions * Add icon, still need to add values underneath chart * restore ws changes to types * Add columns at bottom of chart * Fix reversed average and max in grid * Fix responsiveness issues * Extract utility and data building functions, tool tip and constants * Add comment with link to external calculation docs * Fix tool tip * quick refactor * clean up * refactor calculating min and max for Y axis * set start and end temps once * Add 2f to x axis so tool tip is easier to invoke * review changes to HeatLoad.tsx * All issues except legend and tool type type errors addressed * legend working with valid value for layout * break out legend and fix avg heat load endpoint * Adjust x axis ticks and make design set point a global constant * fix HeatLoadGraphToolTip type error * Remove hard coded data * Add comment to calculateAvgHeatLoadEndPoint * comment out inclusion_override * Fix type errors * re-comment tsconfig commit 98edbe0 Author: AdamFinkle <[email protected]> Date: Mon Dec 16 15:22:38 2024 -0500 Fixed errors that CI workflow caught (#285) * FIxed mypy errors * Fixed black error * Fixed error that pydocstyle caught * Refactor to use dataclass for return value * Refactor to move toward a static function Co-authored-by: Ethan-Strominger <[email protected]> * Refactor to move toward a static function Co-authored-by: Ethan-Strominger <[email protected]> * Refactor to move toward a static function Co-authored-by: Ethan-Strominger <[email protected]> * Refactor to move toward a static function Co-authored-by: Ethan-Strominger <[email protected]> * Made uas an argument and return value * Made self.balance_point_graph an argument and return value * Changed call to _refine_balance_point to a static one. Also removed unnecessary argument. Co-authored-by: Ethan-Strominger <[email protected]> * Made thermostat_set_point an argument of _calculate_balance_point_and_ua Co-authored-by: Ethan-Strominger <[email protected]> * Made winter_processed_energy_bills an argument and return value of _calculate_balance_point_and_ua Co-authored-by: Ethan-Strominger <[email protected]> * FIxed linting errors and made _calculate_balance_point_and_ua static * Removed code related to deriving outliers from data and changed test assertions to make the tests pass. Co-authored-by: Ethan-Strominger <[email protected]> * Removed quotes from calculate method of Home * Changed home instantiation to a factory method Co-authored-by: Ethan-Strominger <[email protected]> * Renamed initialize_ua to process_intermediate_energy_bill to reflect its contents Co-authored-by: Ethan-Strominger <[email protected]> * Removed stdev_pct_max and max_stdev_pct_diff from arguments of _calculate_balance_point_and_ua Co-authored-by: Ethan-Strominger <[email protected]> * Change home.<var> to <var> for non Home variables * Made Home a class with just attributes, no methods * Made Home a class with just attributes, no methods * Made Home a class with just attributes, no methods * Made Home a class with just attributes, no methods * Changed arguments of process_intermediate_energy_bill and calculate_partial_ua to explicitly refer to named quantities and changed the return of process_intermediate_energy_bill to be the same. * Extracted individual calculations from process_intermediate_energy_bill into for loop in Home.calculate * Removed extra arguments from Home.calculate * Ran isort * Removed commented lines and renamed home to home_result --------- Co-authored-by: Ethan Strominger <[email protected]> Co-authored-by: stemgene <[email protected]> Co-authored-by: stemgene <[email protected]> Co-authored-by: Ethan-Strominger <[email protected]> Co-authored-by: Haoyuan Dong <[email protected]> Co-authored-by: Ethan-Strominger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.