Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:CR-22172-parent-app-ns #274

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

oleksandr-codefresh
Copy link

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

@oleksandr-codefresh oleksandr-codefresh changed the base branch from master to release-2.9 January 16, 2024 09:35
@oleksandr-codefresh oleksandr-codefresh changed the title CR-22172-parent-app-ns fix:CR-22172-parent-app-ns Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e8ec3af) 46.67% compared to head (f896f66) 47.11%.
Report is 2 commits behind head on release-2.9.

Files Patch % Lines
...nt_reporter/reporter/application_event_reporter.go 90.90% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.9     #274      +/-   ##
===============================================
+ Coverage        46.67%   47.11%   +0.44%     
===============================================
  Files              276      276              
  Lines            33354    33360       +6     
===============================================
+ Hits             15567    15718     +151     
+ Misses           15704    15539     -165     
- Partials          2083     2103      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…apps. Added `application-namespaces` to run parameter of event-reporter
@oleksandr-codefresh oleksandr-codefresh merged commit f663c78 into release-2.9 Jan 16, 2024
11 of 13 checks passed
@ATGardner ATGardner deleted the CR-22172-parent-app-ns branch July 18, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants