Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.4.3 Ready code #8098

Merged
merged 74 commits into from
Oct 26, 2023
Merged

4.4.3 Ready code #8098

merged 74 commits into from
Oct 26, 2023

Commits on Sep 24, 2023

  1. Add note on incompatibility of general rules for file validation use

    @dgvirtual
    dgvirtual committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    c672b2b View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Implement proposed fixes for previous suggestions

    @dgvirtual
    dgvirtual committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    20b496b View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. correct table format

    @dgvirtual
    dgvirtual committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    db7041c View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. docs: fix @var type

    @kenjis
    kenjis committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    8513503 View commit details
    Browse the repository at this point in the history

  2. test: add assertion

    @kenjis
    kenjis committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    cc185a8 View commit details
    Browse the repository at this point in the history

  3. fix: getFilterCaller() does not support Filter classes as array

    @kenjis
    kenjis committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    66b572a View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. docs: fix incorrect descriptions for pre_system and post_system

    @kenjis
    kenjis committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    2b836f9 View commit details
    Browse the repository at this point in the history

  2. docs: add changelog

    @kenjis
    kenjis committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    50e7867 View commit details
    Browse the repository at this point in the history

  3. docs: add descriptions to upgrade_4xx Hooks

    @kenjis
    kenjis committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    82ccf15 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. fix: fix the field named data will produce bugged output.

    @ping-yee
    ping-yee committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    0995b38 View commit details
    Browse the repository at this point in the history

  2. test: add the test case for the bug fix.

    @ping-yee
    ping-yee committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    df4b7c6 View commit details
    Browse the repository at this point in the history

  3. style: run rector.

    @ping-yee
    ping-yee committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    39903e6 View commit details
    Browse the repository at this point in the history

  4. docs: add changelog and upgrade for v4.4.3

    @kenjis
    kenjis committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    f098f4e View commit details
    Browse the repository at this point in the history

  5. docs: update RELEASE.md

    @kenjis
    kenjis committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    60870b7 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. Merge pull request #8065 from kenjis/docs-changelog-443 

    docs: add changelog and upgrade for v4.4.3
    @kenjis
    kenjis authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    f8ae500 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #8066 from kenjis/update-RELEASE.md 

    docs: update RELEASE.md
    @kenjis
    kenjis authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    9e5cdd0 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #8058 from kenjis/fix-filters-var-type 

    fix: FilterTestTrait::getFilterCaller() does not support Filter classes as array
    @kenjis
    kenjis authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    4c09ca3 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. phpstan: remove unneeded ignoreErrors

    @datamweb
    datamweb committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    b5e3212 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #8070 from datamweb/develop 

    phpstan: remove unneeded ignoreErrors
    @kenjis
    kenjis authored Oct 22, 2023
    Configuration menu
    Copy the full SHA
    3d2f80c View commit details
    Browse the repository at this point in the history

  3. docs: improve description

    @kenjis
    kenjis committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    bd7b3b5 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #8055 from kenjis/docs-fix-event-points 

    docs: fix event points descriptions
    @kenjis
    kenjis authored Oct 22, 2023
    Configuration menu
    Copy the full SHA
    0ab6fb9 View commit details
    Browse the repository at this point in the history

  5. Revert "docs: fix event points descriptions"

    @kenjis
    kenjis authored Oct 22, 2023
    Configuration menu
    Copy the full SHA
    5d5487c View commit details
    Browse the repository at this point in the history

  6. Merge pull request #8075 from codeigniter4/revert-8055-docs-fix-event… 

    …-points

Revert "docs: fix event points descriptions"
    @kenjis
    kenjis authored Oct 22, 2023
    Configuration menu
    Copy the full SHA
    15b2ea4 View commit details
    Browse the repository at this point in the history

  7. docs: fix incorrect descriptions for pre_system and post_system

    @kenjis
    kenjis committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    e09cfec View commit details
    Browse the repository at this point in the history

  8. docs: add changelog

    @kenjis
    kenjis committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    bc6229b View commit details
    Browse the repository at this point in the history

  9. docs: add descriptions to upgrade_4xx Hooks

    @kenjis
    kenjis committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    f0f5713 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. chore(deps): bump actions/setup-node from 3.0.0 to 4.0.0 

    Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.0.0 to 4.0.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3.0.0...v4.0.0)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot
    dependabot[bot] authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    58b67f7 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #8076 from kenjis/docs-fix-event-points-v2 

    docs: fix event points descriptions
    @kenjis
    kenjis authored Oct 23, 2023
    Configuration menu
    Copy the full SHA
    652bb44 View commit details
    Browse the repository at this point in the history

  3. docs: add new section titles "Confirming Namespaces" and "Application… 

    … Namespace"
    @kenjis
    kenjis committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    cfe8b09 View commit details
    Browse the repository at this point in the history

  4. docs: add link to function page

    @kenjis
    kenjis committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    1ab5845 View commit details
    Browse the repository at this point in the history

  5. docs: add link to "Helper Functions"

    @kenjis
    kenjis committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    bb1369a View commit details
    Browse the repository at this point in the history

  6. docs: fix description for helper loading 

    and add "Auto-Discovery and Composer Packages"
    @kenjis
    kenjis committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    fa31844 View commit details
    Browse the repository at this point in the history

  7. docs: fix typo in doc comment

    @kenjis
    kenjis committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    59ae2e6 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. docs: fix typo

    @kenjis
    kenjis authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    fde934e View commit details
    Browse the repository at this point in the history

  2. Merge pull request #7969 from dgvirtual/add_fileValidation_explanation 

    Add note that only file rules can be used to validate files
    @kenjis
    kenjis authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    6f81e6e View commit details
    Browse the repository at this point in the history

  3. Merge pull request #8083 from codeigniter4/dependabot/github_actions/… 

    …actions/setup-node-4.0.0

chore(deps): bump actions/setup-node from 3.0.0 to 4.0.0
    @kenjis
    kenjis authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    8b1d9fc View commit details
    Browse the repository at this point in the history

  4. add dbgroup to model template only when specified as an option

    @sammyskills
    sammyskills committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    dc55d41 View commit details
    Browse the repository at this point in the history

  5. applied rector fix

    @sammyskills
    sammyskills committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    fc8b036 View commit details
    Browse the repository at this point in the history

  6. fixed phpunit failure

    @sammyskills
    sammyskills committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    10815db View commit details
    Browse the repository at this point in the history

  7. applied code review suggestion

    @sammyskills
    sammyskills committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    23eb997 View commit details
    Browse the repository at this point in the history

  8. test: add tests for exact_length

    @kenjis
    kenjis committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    26a3e75 View commit details
    Browse the repository at this point in the history

  9. fix: exact_length does not validate int values

    @kenjis
    kenjis committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    391723b View commit details
    Browse the repository at this point in the history

  10. chore(deps-dev): update rector/rector requirement from 0.18.5 to 0.18.6 

    Updates the requirements on [rector/rector](https://github.com/rectorphp/rector) to permit the latest version.
- [Release notes](https://github.com/rectorphp/rector/releases)
- [Commits](rectorphp/rector@0.18.5...0.18.6)

---
updated-dependencies:
- dependency-name: rector/rector
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot
    dependabot[bot] authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    3808925 View commit details
    Browse the repository at this point in the history

  11. Merge pull request #8089 from codeigniter4/dependabot/composer/rector… 

    …/rector-0.18.6

chore(deps-dev): update rector/rector requirement from 0.18.5 to 0.18.6
    @samsonasik
    samsonasik authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    4b43eb0 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Merge pull request #8077 from sammyskills/fix/dbgroup-tpl 

    fix: add dbgroup to model template only when specified as an option
    @kenjis
    kenjis authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    b56c85c View commit details
    Browse the repository at this point in the history

  2. Update phpstan-codeigniter to v1.4.1

    @paulbalandan
    paulbalandan committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    2969640 View commit details
    Browse the repository at this point in the history

  3. Fix Modules does not extend BaseConfig

    @paulbalandan
    paulbalandan committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    94130de View commit details
    Browse the repository at this point in the history

  4. Inject Modules into constructor

    @paulbalandan
    paulbalandan committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    89f1cc6 View commit details
    Browse the repository at this point in the history

  5. Use static setter

    @paulbalandan
    paulbalandan committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    3142108 View commit details
    Browse the repository at this point in the history

  6. Simplify test

    @paulbalandan
    paulbalandan committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    61bbbca View commit details
    Browse the repository at this point in the history

  7. Merge pull request #8036 from paulbalandan/update-phpstan-codeigniter 

    Update phpstan-codeigniter and fix errors on Modules
    @kenjis
    kenjis authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    130be04 View commit details
    Browse the repository at this point in the history

  8. docs: fix by proofreading 

    Co-authored-by: MGatner <[email protected]>
    @kenjis @MGatner
    kenjis and MGatner authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    c64959e View commit details
    Browse the repository at this point in the history

  9. Merge pull request #8084 from kenjis/docs-fix-helper-loading 

    docs: fix helper loading
    @kenjis
    kenjis authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    b92057c View commit details
    Browse the repository at this point in the history

  10. Merge pull request #8088 from kenjis/fix-validation-exact_length 

    fix: [Validation] exact_length does not pass int values
    @kenjis
    kenjis authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    f780d75 View commit details
    Browse the repository at this point in the history

  11. Merge pull request #8074 from kenjis/docs-model-DBGroup 

    docs: improve $DBGroup description in Model
    @kenjis
    kenjis authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    7cd5c99 View commit details
    Browse the repository at this point in the history

  12. test: reset state after testing 

    Mocks should be removed.
    @kenjis
    kenjis committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    ccbddae View commit details
    Browse the repository at this point in the history

  13. docs: add @psalm-suppress

    @kenjis
    kenjis committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    bfecd50 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. feat: add reset() for testing

    @kenjis
    kenjis committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    469eef4 View commit details
    Browse the repository at this point in the history

  2. test: add tearDown() and tweak setUp()

    @kenjis
    kenjis committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f42244f View commit details
    Browse the repository at this point in the history

  3. Merge pull request #8095 from kenjis/test-fix-BaseConfigTest 

    test: fix BaseConfigTest
    @kenjis
    kenjis authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    6c788de View commit details
    Browse the repository at this point in the history

  4. test: remove unneeded table template

    @kenjis
    kenjis authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    4c0eab5 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #8054 from ping-yee/231018_generate_table 

    fix: [Table] field named `data` will produce bugged output
    @kenjis
    kenjis authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    407c108 View commit details
    Browse the repository at this point in the history

  6. fix: detailed error report is displayed in production environment 

    php > ini_set('display_errors', '0');
php > var_dump(ini_get('display_errors'));
string(1) "0"

php > ini_set('display_errors', 0);
php > var_dump(ini_get('display_errors'));
string(1) "0"

php > ini_set('display_errors', false);
php > var_dump(ini_get('display_errors'));
string(0) ""

php > ini_set('display_errors', null);
php > var_dump(ini_get('display_errors'));
string(0) ""

php > ini_set('display_errors', 'off');
php > var_dump(ini_get('display_errors'));
string(3) "off"
    @kenjis
    kenjis committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    1874e62 View commit details
    Browse the repository at this point in the history

  7. docs: add comments

    @kenjis
    kenjis committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    1be8686 View commit details
    Browse the repository at this point in the history

  8. fix: SHOW_DEBUG_BACKTRACE does not work in web

    @kenjis
    kenjis committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    4a10c99 View commit details
    Browse the repository at this point in the history

  9. style: fix sytle 

    For consistency.
    @kenjis
    kenjis committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9dda86d View commit details
    Browse the repository at this point in the history

  10. test: add test for determineView()

    @kenjis
    kenjis committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    11613d6 View commit details
    Browse the repository at this point in the history

  11. docs: improve docs

    @kenjis
    kenjis committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    2a99bdf View commit details
    Browse the repository at this point in the history

  12. docs: add changelog and upgrade

    @kenjis
    kenjis committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f26b9dc View commit details
    Browse the repository at this point in the history

  13. refactor: replace str_ireplace() with in_array() 

    php > ini_set('display_errors', '1');
php > var_dump(ini_get('display_errors'));
string(1) "1"

php > ini_set('display_errors', 1);
php > var_dump(ini_get('display_errors'));
string(1) "1"

php > ini_set('display_errors', true);
php > var_dump(ini_get('display_errors'));
string(1) "1"

php > ini_set('display_errors', 'true');
php > var_dump(ini_get('display_errors'));
string(4) "true"
    @kenjis
    kenjis committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f251a3c View commit details
    Browse the repository at this point in the history

  14. Merge pull request from GHSA-hwxf-qxj7-7rfj 

    fix: detailed error report is displayed in production environment
    @kenjis
    kenjis authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    423569f View commit details
    Browse the repository at this point in the history

  15. Prep for 4.4.3 release

    @kenjis
    kenjis committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    a0d7524 View commit details
    Browse the repository at this point in the history

  16. docs: fix links

    @kenjis
    kenjis committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    84c8f88 View commit details
    Browse the repository at this point in the history

  17. Merge pull request #8097 from codeigniter4/release-4.4.3 

    Prep for 4.4.3 release
    @kenjis
    kenjis authored Oct 26, 2023
    Configuration menu
    Copy the full SHA
    2b3ec1a View commit details
    Browse the repository at this point in the history