4.4.6 Ready code #8575
Merged
4.4.6 Ready code #8575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return type is integer, not boolean.
style: apply new options to `phpdoc_align` fixer
test: refactor ImageMagickHandlerTest
docs: add changelog and upgrade for v4.4.6
docs: add how to update PHPStan baseline
fix: [OCI8] getFieldData() returns incorrect `default` value
docs: improve contributing/signing.md
docs: improve debugging
fix: Time::createFromTimestamp() returns Time with UTC
refactor: small improvement in `loadInNamespace` Autoloader
docs: add "Deployment to Shared Hosting Services"
docs: use word "UNIX timestamp" for consistency
docs: add note for index.php change
The return value (usually true on success, false on failure) https://www.php.net/manual/en/sessionhandlerinterface.close.php#refsect1-sessionhandlerinterface.close-returnvalues
Now if we add type int to controller params, it works. So we must allow type-casting on controller parameters in the future.
fix: PHPDoc types in controller.tpl.php
fix: [Session] Redis session race condition
Prep for 4.4.6 release
ddevsr
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.