docs: Small typos in libraries/uploaded_files.rst #8889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small typos in libraries/uploaded_files.rst
kenjis
reviewed
May 14, 2024
kenjis
reviewed
May 14, 2024
| @@ -83,9 +83,9 @@ this code and save it to your **app/Controllers** directory: | |||
|
|
|||
| .. literalinclude:: uploaded_files/002.php | |||
|
|
|||
| Since the value of a file upload HTML field doesn't exist, and is stored in the | |||
| Since HTML file element has no value attribute, and the upload file is stored in the | |||
There was a problem hiding this comment.
The original sentence is also difficult to understand, but this also seems inaccurate.
The original says there is no data for uploaded files in $_POST.
I don't understand what "HTML file element has no value attribute" says.
There was a problem hiding this comment.
I sent another PR to improve the description. See #8910
kenjis
reviewed
May 14, 2024
| @@ -83,9 +83,9 @@ this code and save it to your **app/Controllers** directory: | |||
|
|
|||
| .. literalinclude:: uploaded_files/002.php | |||
|
|
|||
| Since the value of a file upload HTML field doesn't exist, and is stored in the | |||
| Since HTML file element has no value attribute, and the upload file is stored in the | |||
| ``$_FILES`` global, only :ref:`rules-for-file-uploads` can be used to validate | |||
There was a problem hiding this comment.
"the upload file is stored in the $_FILES global"
This is not true or misleading.
The global $_FILES contains all the uploaded file information.
Rollback misleading changes in libraries/uploaded_files.rst
kenjis
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small typos in libraries/uploaded_files.rst
Checklist: