Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: remove unneeded x permissions #8918

Merged
merged 1 commit into from
May 30, 2024
Merged

style: remove unneeded x permissions #8918

merged 1 commit into from
May 30, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 28, 2024 •
edited
Loading

Description
See https://forum.codeigniter.com/showthread.php?tid=90959

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

paulbalandan
paulbalandan approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Can we have though in a separate PR an autoreview test to prevent similar files for having +x permissions in the future? Maybe a utils/check_file_permissions.sh file that checks whether non-shell files will not have extra permissions.

@kenjis kenjis mentioned this pull request May 30, 2024
Merged
1 task
@kenjis kenjis merged commit f2b8892 into codeigniter4:develop May 30, 2024
41 checks passed
@kenjis kenjis deleted the fix-file-permissions branch May 30, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddevsr ddevsr ddevsr approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

@datamweb datamweb datamweb approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kenjis @michalsn @datamweb @paulbalandan @ddevsr