Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove JsonThrowOnErrorRector and FinalizePublicClassConstantRector from skip() config #8919

Merged
merged 1 commit into from
May 29, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented May 29, 2024

Description
as no longer part of sets

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

…ector from skip() config as no longer part of sets
@samsonasik
Copy link
Member Author

Ready to merge 👍

@samsonasik
Copy link
Member Author

Thank you @michalsn for the review, let's merge 👍

@samsonasik samsonasik merged commit 117dc1d into codeigniter4:develop May 29, 2024
9 checks passed
@samsonasik samsonasik deleted the chore-clean-rector-skip branch May 29, 2024 11:51
kenjis added a commit to kenjis/codeigniter4-devkit that referenced this pull request May 30, 2024
@kenjis kenjis mentioned this pull request May 30, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants