Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional information in gemspec #81

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ gemfile:
- gemfiles/Gemfile.rails-3.2.x
- gemfiles/Gemfile.rails-4.0.x
- gemfiles/Gemfile.rails-4.1.x
- gemfiles/Gemfile.rails-4.2.x
- gemfiles/Gemfile.rails-5.0.x
- gemfiles/Gemfile.rails-5.1.x

matrix:
exclude:
Expand All @@ -24,9 +24,9 @@ matrix:
- rvm: 2.1.10
gemfile: gemfiles/Gemfile.rails-5.0.x
- rvm: 2.0.0
gemfile: gemfiles/Gemfile.rails-5.1.x
gemfile: Gemfile
- rvm: 2.1.10
gemfile: gemfiles/Gemfile.rails-5.1.x
gemfile: Gemfile

before_install:
- gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true
Expand Down
24 changes: 7 additions & 17 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,22 +1,12 @@
source "http://rubygems.org"
# -*- ruby -*-

# Declare your gem's dependencies in invoicing.gemspec.
# Bundler will treat runtime dependencies like base dependencies, and
# development dependencies will be added by default to the :development group.
gemspec
source 'http://rubygems.org'

# Declare any dependencies that are still in development here instead of in
# your gemspec. These might include edge Rails or gems from your path or
# Git. Remember to move these dependencies to your gemspec before releasing
# your gem to rubygems.org.
gemspec

gem "pry-rails"
gem "minitest"
gem 'minitest'
gem 'rails', '~> 5.1.0'

# Issue in database cleaner for sqlite support
# https://github.com/bmabey/database_cleaner/issues/224
# https://github.com/bmabey/database_cleaner/pull/241
gem "database_cleaner", "~> 1.0.1"
gem "rake", "~> 11"
gem 'database_cleaner', github: 'tommeier/database_cleaner', branch: 'fix-superclass-1-1-1'

gem "coveralls", "~> 0.7.0", require: false
gem 'coveralls', '~> 0.7.0', require: false
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
source "http://rubygems.org"

gemspec path: ".."
gem "rails", "~> 5.1.0"
gem "minitest"
gem "rails", "~> 4.2.0"

gem "database_cleaner", github: "tommeier/database_cleaner", branch: "fix-superclass-1-1-1"

Expand Down
42 changes: 25 additions & 17 deletions invoicing.gemspec
Original file line number Diff line number Diff line change
@@ -1,28 +1,36 @@
$:.push File.expand_path("../lib", __FILE__)
$LOAD_PATH.push File.expand_path('lib', __dir__)

# Maintain your gem's version:
require "invoicing/version"
require 'invoicing/version'

# Describe your gem and declare its dependencies:
Gem::Specification.new do |s|
s.name = "invoicing"
s.name = 'invoicing'
s.version = Invoicing::VERSION
s.authors = ["Martin Kleppmann"]
s.email = ["@martinkl"]
s.homepage = "http://invoicing.codemancers.com/"
s.summary = "Ruby Invoicing Framework"
s.license = 'MIT'
s.authors = ['Martin Kleppmann', 'Codemancers']
s.email = ['[email protected]']
s.homepage = 'http://invoicing.codemancers.com/'
s.summary = 'Ruby Invoicing Framework'
s.description = <<-DESC
This is a framework for generating and displaying invoices (ideal for commercial
Rails apps). It allows for flexible business logic; provides tools for tax
handling, commission calculation etc. It aims to be both developer-friendly
and accountant-friendly.
DESC
This is a framework for generating and displaying invoices (ideal for commercial
Rails apps). It allows for flexible business logic; provides tools for tax
handling, commission calculation etc. It aims to be both developer-friendly
and accountant-friendly.
DESC

s.files = Dir["{lib}/**/*", "LICENSE", "Rakefile", "README.md"]
s.post_install_message = <<-POST_INSTALL
1.2.x will be the last version to support Ruby < 2.4 and Rails < 5.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start the message as a Deprecation Warning: ?

Copy link
Author

@thegeorgeous thegeorgeous Aug 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is generally used for classes. Maybe we should add another for FindSubclasses instead?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! that works better. Since the plan is to remove the class, it would be better to warn the usage of the class as well 👍

The next version will introduce breaking changes including removal of the `FindSubClasses` class
POST_INSTALL

s.add_dependency "rails", ">= 3.2.13"
s.files = Dir['{lib}/**/*', 'LICENSE', 'Rakefile', 'README.md']

s.add_development_dependency "sqlite3", "< 1.4"
s.add_development_dependency "minitest"
s.add_development_dependency "uuid"
s.required_ruby_version = '>= 2.0.0'

s.add_runtime_dependency 'rails', '>= 3.2.13', '< 5.2'

s.add_development_dependency 'minitest', '> 4'
s.add_development_dependency 'sqlite3', '< 1.4'
s.add_development_dependency 'uuid', '> 2'
end
2 changes: 1 addition & 1 deletion lib/invoicing/version.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module Invoicing
module Version
MAJOR = 1
MINOR = 1
MINOR = 2
BUILD = 0

def to_a
Expand Down