Bug Fix For When "/" Overides external text #2894
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obafemitayor
requested review from
neSpecc,
gohabereg,
TatianaFomina and
ilyamore88
as code owners
neSpecc
reviewed
Dec 21, 2024
src/components/modules/ui.ts
Outdated
| @@ -477,6 +477,12 @@ export default class UI extends Module<UINodes> { | |||
| * @param {KeyboardEvent} event - keyboard event | |||
| */ | |||
| private documentKeydown(event: KeyboardEvent): void { | |||
There was a problem hiding this comment.
this method is designed to handle keydowns on document. I'm afraid that this change break something like inserting new block on Enter when no block is focused, etc.
The possible problem place is the BlockEvents@slachPressed
this.Editor.Caret.insertContentAtCaretPosition('/');
So it is expected to see a fix there.
There was a problem hiding this comment.
@neSpecc I have moved the fix to BlockEvents
There was a problem hiding this comment.
Hello @neSpecc, have you had a chance to check this again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
What Changed
Testing Strategy
https://www.loom.com/share/a1ab1fa550624cb39f8765eda68af1ca