Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear probing map #514

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

nubol23
Copy link
Contributor

@nubol23 nubol23 commented Oct 7, 2022

Adds Linear Probing Hash Map templated implementation in utils.

Currently support adition and search

TODO: support deletion

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #514 (fa2a73b) into master (8f419fd) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #514   +/-   ##
=========================================
  Coverage   98.528%   98.528%           
=========================================
  Files           32        32           
  Lines         4010      4010           
=========================================
  Hits          3951      3951           
  Misses          59        59           

Impacted file tree graph

Copy link
Member

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice addition. However I think we should expose this via PyDataStructs API. Like LinearProbingMap class in Python API and will have the same methods/attributes as dict but will use your C++ implementation. Can you give this idea a try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants