Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silently substitute synonyms for tags #1437

Merged
merged 3 commits into from
Oct 20, 2024
Merged

Conversation

ArtOfCode-
Copy link
Member

Instead of showing an error when a user tries to use a synonym instead of the tag it points to, just substitute the synonym for the primary tag.

May assist with #1436, but I'm not sure it's the full answer.

@ArtOfCode- ArtOfCode- requested a review from a team October 20, 2024 18:48
Copy link
Member

@Oaphi Oaphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Oaphi Oaphi merged commit 80e957e into develop Oct 20, 2024
7 checks passed
@Oaphi Oaphi deleted the art/1436/substitute-synonyms branch October 20, 2024 20:30
@trichoplax
Copy link
Contributor

The error described in #1436 relates to editing a tag itself, not editing the tags on a post, so I've added some comments there including more detailed steps to reproduce.

Note that:

@ArtOfCode-
Copy link
Member Author

@trichoplax when I dug into this it wasn't quite being handled on the front end - it would suggest the primary tag instead of the synonym, but it still gives the option to create a new tag. This just cleans up that loose end - anyone selecting the new tag anyway will have it replaced with the synonym's primary.

@trichoplax
Copy link
Contributor

Thanks for explaining - I didn't pick up that when testing it. I just pressed enter after typing in the tag name, and it was automatically replaced, so I overlooked the option to override that behaviour. Good to have this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants