-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tslint and prettierrc #76
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: prathambatra <[email protected]>
@jatinkatyal13 I have setup this. but on running npm lint I got lot of errors. I don't know much about prettier and linting. |
Are you getting errors for 'test' directory? because I have used semi colon and tabWidth = 4 in my PRs 😅 ( I realized it later :( ) |
That's what linting is for, yes it will have a lot of errors because the code wasn't written in a consistent manner. We should aim to have no linting errors ideally but code would function nonetheless |
what should i do now? all configs are fine? |
LGTM! |
travis CI build is failing |
@jatinkatyal13 |
back merge with the current Head and the test should not fail |
Signed-off-by: prathambatra [email protected]
fixes #72