Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tslint and prettierrc #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prathambatra
Copy link

Signed-off-by: prathambatra [email protected]
fixes #72

Signed-off-by: prathambatra <[email protected]>
@prathambatra
Copy link
Author

@jatinkatyal13 I have setup this. but on running npm lint I got lot of errors. I don't know much about prettier and linting.

@prabalsingh24
Copy link
Contributor

Are you getting errors for 'test' directory? because I have used semi colon and tabWidth = 4 in my PRs 😅 ( I realized it later :( )

@jatinkatyal13
Copy link
Contributor

That's what linting is for, yes it will have a lot of errors because the code wasn't written in a consistent manner. We should aim to have no linting errors ideally but code would function nonetheless

@prathambatra
Copy link
Author

what should i do now? all configs are fine?

@jatinkatyal13
Copy link
Contributor

LGTM!

@prathambatra
Copy link
Author

prathambatra commented May 25, 2020

travis CI build is failing

@prathambatra prathambatra marked this pull request as ready for review May 25, 2020 12:06
@prabalsingh24
Copy link
Contributor

prabalsingh24 commented May 26, 2020

travis CI build is failing

@jatinkatyal13
travis-ci is running this command
docker exec judgecompose_api_1 scripts/wait-for-it.sh -t 180 api:3737 -- npm run seedlangs
which is creating an API key before the tests begin. And because the same api key value is used here beforeEach. it is throwing an error :)

@prathambatra
Copy link
Author

@jatinkatyal13

@jatinkatyal13
Copy link
Contributor

back merge with the current Head and the test should not fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor unstructured codebase and integrate linting checks
3 participants