Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding deploy.yaml pattern for ping-pong-mesh #8

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

jsnctl
Copy link
Contributor

@jsnctl jsnctl commented Dec 9, 2024

Making ping-pong-mesh consistent with the pattern used in ping-pong (i.e. adding deploy.yaml for each)

@jsnctl jsnctl self-assigned this Dec 9, 2024
@jsnctl jsnctl marked this pull request as ready for review December 9, 2024 09:47
@jsnctl jsnctl enabled auto-merge December 9, 2024 09:54
@jsnctl
Copy link
Contributor Author

jsnctl commented Dec 9, 2024

@mattbates it looks as if the existing branch has some conflicts that need to be resolved prior to merge, and it's a fairly big set of changes as well.

This is small subset of those and will unblock the CI build for the multi-mesh case as the Action needs to do a fresh checkout on each invocation

@jsnctl jsnctl merged commit 52bc413 into main Dec 9, 2024
2 checks passed
@jsnctl jsnctl deleted the jsnctl/adding-deployments-to-mesh-cases branch December 9, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants