Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve workflow speed & build binaries #144

Merged
merged 9 commits into from
Feb 7, 2025
Merged

Improve workflow speed & build binaries #144

merged 9 commits into from
Feb 7, 2025

Conversation

kipz
Copy link
Contributor

@kipz kipz commented Jan 31, 2025 •
edited
Loading

  • Avoid download go-modules explicitly (setup-go is caching for us)
  • Use pre-built cloud-provider-kind image instead of rebuilding each time
  • Build binaries for linux/darwin - amd64/arm64 (for use in other builds) on tag and uploads to a draft release
  • Draft release is updated on each push with changelog

@kipz
chore: Improve speed workflows
a5c7518 
* Avoid the module download. setup-go action is caching for us
* Use pre-built cloud-provider-kind image instead of rebuilding
@kipz kipz changed the title feat: cache go modules. use pre-build kind provider Improve workflow speed (& reduce costs) Jan 31, 2025
@kipz kipz marked this pull request as ready for review January 31, 2025 22:15
@kipz kipz changed the title Improve workflow speed (& reduce costs) Improve workflow speed & build binaries Jan 31, 2025
@kipz kipz requested review from markgoddard and nialdaly February 3, 2025 21:08
markgoddard
markgoddard previously requested changes Feb 4, 2025
View reviewed changes
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
tests/integration/install-kind.sh Outdated Show resolved Hide resolved
tests/integration/install-kind.sh Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@kipz kipz self-assigned this Feb 4, 2025
@kipz kipz enabled auto-merge February 7, 2025 11:05
@kipz kipz disabled auto-merge February 7, 2025 11:05
@kipz kipz enabled auto-merge (squash) February 7, 2025 11:06
@kipz kipz dismissed markgoddard’s stale review February 7, 2025 11:46

Discussed in chat that this is fine as long as other projects are updated and folks are told. done.

@kipz kipz requested a review from jsnctl February 7, 2025 11:47
markgoddard
markgoddard approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@kipz kipz merged commit 249bcb8 into main Feb 7, 2025
6 of 7 checks passed
@kipz kipz deleted the kipz/perf branch February 7, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgoddard markgoddard markgoddard approved these changes

@nialdaly nialdaly Awaiting requested review from nialdaly

@mattbates mattbates Awaiting requested review from mattbates

@jsnctl jsnctl Awaiting requested review from jsnctl

Assignees

@kipz kipz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kipz @markgoddard @jsnctl